Skip to content

[release/10.0.1xx] [Signing] Sign unsigned libraries#26153

Merged
dalexsoto merged 1 commit into
release/10.0.1xxfrom
dev/alex/sign10
Jul 17, 2026
Merged

[release/10.0.1xx] [Signing] Sign unsigned libraries#26153
dalexsoto merged 1 commit into
release/10.0.1xxfrom
dev/alex/sign10

Conversation

@dalexsoto

@dalexsoto dalexsoto commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Backport [Signing] Singn unsigned libraries #25966 to release/10.0.1xx.
  • Move BouncyCastle.Cryptography.dll, MQTTnet.dll, and System.Reactive.dll from Skip to ThirdParty so the signing pipeline signs these unsigned libraries.

Validation

  • xmllint --noout dotnet/Workloads/SignList.xml dotnet/Workloads/SignList.targets
  • Verified each moved assembly occurs exactly once in ThirdParty and not in Skip.
  • Verified the branch diff contains only dotnet/Workloads/SignList.xml and matches merged commit 58baaa193ef8dce8aa733529c3aae2e196a71475.
  • MSBuild evaluation was not run because the repository-local .NET SDK is not bootstrapped (make dotnet -C builds).

@dalexsoto
[Signing] Sign unsigned libraries
d08daad 
Backport of #25966.

(cherry picked from commit 58baaa1)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 65de688c-78dd-49a5-8e1e-e7472fffeb8a
Copilot AI review requested due to automatic review settings July 17, 2026 01:39
Copilot AI reviewed Jul 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backports the signing-list change from #25966 into release/10.0.1xx so the workload signing pipeline will sign previously-unsigned third-party assemblies.

Changes:

  • Remove BouncyCastle.Cryptography.dll, MQTTnet.dll, and System.Reactive.dll from the Skip list.
  • Add those assemblies to the ThirdParty list to ensure they’re included in signing.

@dalexsoto
dalexsoto enabled auto-merge (squash) July 17, 2026 01:41
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #d08daad] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: d08daada243b0d33b07c3914e655e619b966017d [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #d08daad] Build passed (Build packages) ✅

Pipeline on Agent
Hash: d08daada243b0d33b07c3914e655e619b966017d [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

✅ [PR Build #d08daad] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: d08daada243b0d33b07c3914e655e619b966017d [PR build]

@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: d08daada243b0d33b07c3914e655e619b966017d [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

This comment has been minimized.

Sign in to view
@vs-mobiletools-engineering-service2

vs-mobiletools-engineering-service2 commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

🚀 [CI Build #d08daad] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 167 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 14 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 16 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (macOS): All 16 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 14 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: d08daada243b0d33b07c3914e655e619b966017d [PR build]

@dalexsoto
dalexsoto merged commit 02e58e4 into release/10.0.1xx Jul 17, 2026
49 checks passed
@dalexsoto
dalexsoto deleted the dev/alex/sign10 branch July 17, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@rolfbjarne rolfbjarne rolfbjarne approved these changes

Assignees

No one assigned

Labels

copilot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dalexsoto @vs-mobiletools-engineering-service2 @rolfbjarne