[tests] Delete legacy mmptest suite and port two tests to tests/dotnet/UnitTests. Fixes #26145.#26146
[tests] Delete legacy mmptest suite and port two tests to tests/dotnet/UnitTests. Fixes #26145.#26146rolfbjarne wants to merge 1 commit into
Conversation
…t/UnitTests The tests/mmptest/ suite tested the classic `mmp` bundler and the legacy Xamarin.Mac SDK, none of which exist after the migration to .NET. The project targets .NET Framework v4.7.2 and references a `mmp.exe` that's no longer built, so it can't build and hasn't run in a long time. Delete the entire suite, and port the two testcases that still cover relevant behavior into the running tests/dotnet/UnitTests suite: - BuildWithUnusualAssemblyName: build an app with an assembly name containing non-ASCII characters, spaces or a comma. - HardenedRuntimeCodesign: verify enabling the hardened runtime passes the expected options to codesign. Also remove the now-orphaned references to the suite: - the /tests/mmptest CODEOWNERS entry - the MmpTestFramework native test framework - the dead FrameworkBuilder helper in tests/common/mac/ProjectTestHelpers.cs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #e92097a] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 1 tests failed, 183 tests passed. Failures❌ dotnettests tests (macOS) [attempt 2]1 tests failed, 0 tests passed.Failed tests
Html Report (VSDrops) Download ❌ monotouch tests (tvOS)🔥 Failed catastrophically on VSTS: test results - monotouch_tvos (no summary found). Html Report (VSDrops) Download Successes✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The tests/mmptest/ suite tested the classic
mmpbundler and the legacy Xamarin.Mac SDK, none of which exist after the migration to .NET. The project targets .NET Framework v4.7.2 and references ammp.exethat's no longer built, so it can't build and hasn't run in a long time.Delete the entire suite, and port the two testcases that still cover relevant behavior into the running tests/dotnet/UnitTests suite:
Also remove the now-orphaned references to the suite:
Fixes #26145.
🤖 Pull request created by Copilot