Skip to content

[MetricKit] Fix an issue with availability attributes. #22810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2025
Merged

[MetricKit] Fix an issue with availability attributes. #22810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf9bfcd
[MetricKit] Fix an issue with availability attributes.
rolfbjarne May 15, 2025
ad1d4b9
Merge remote-tracking branch 'origin/main' into dev/rolf/metrickit
rolfbjarne May 16, 2025
c5e14eb
Merge remote-tracking branch 'origin/main' into dev/rolf/metrickit
rolfbjarne May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/MetricKit/MXMetaData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,13 @@ public virtual NSDictionary DictionaryRepresentation {
get {
if (SystemVersion.IsAtLeastXcode12)
return _DictionaryRepresentation14;
else
else {
#pragma warning disable CA1416 // This call site is reachable on: 'ios' 14.0 and later, 'maccatalyst' 14.0 and later, 'macOS/OSX' 12.0 and later. 'MXMetaData._DictionaryRepresentation13' is only supported on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416) [/Users/rolf/work/dotnet/macios/main/macios/src/build/dotnet/MacCatalyst/csproj/platform/Microsoft.MacCatalyst.csproj]
#pragma warning disable CA1422 // This call site is reachable on: 'ios' 14.0 and later, 'maccatalyst' 14.0 and later, 'macOS/OSX' 12.0 and later. 'MXMetaData._DictionaryRepresentation13' is obsoleted on: 'ios' 14.0 and later, 'maccatalyst' 14.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422) [/Users/rolf/work/dotnet/macios/main/macios/src/build/dotnet/MacCatalyst/csproj/platform/Microsoft.MacCatalyst.csproj]
return _DictionaryRepresentation13;
#pragma warning restore CA1422
#pragma warning restore CA1416
}
}
}
}
Expand Down
Loading