Skip to content

Improve diagnostics when looking for provisioning profiles valid for a set of certificates. #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 3 commits into from
Jun 23, 2025
Merged

Improve diagnostics when looking for provisioning profiles valid for a set of certificates. #134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a68e315
Improve diagnostics when looking for provisioning profiles valid for …
rolfbjarne Jun 20, 2025
661095a
Simplify
rolfbjarne Jun 20, 2025
a90087c
Merge remote-tracking branch 'origin/main' into dev/rolf/improve-diag…
rolfbjarne Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions Xamarin.MacDev/MobileProvisionIndex.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,12 +723,12 @@ public static IList<MobileProvision> GetMobileProvisions (MobileProvisionPlatfor
continue;
}

foreach (var cert in profile.DeveloperCertificates) {
if (!thumbprints.Contains (cert.Thumbprint)) {
failures?.Add ($"The profile '{profile.Name}' might not be applicable because its developer certificate (of {profile.DeveloperCertificates.Count} certificates) {cert.Name}'s thumbprint ({cert.Thumbprint}) is not in the list of accepted thumbprints ({string.Join (", ", thumbprints)}).");
continue;
}

var anyMatchingCerts = profile.DeveloperCertificates.Any (cert => thumbprints.Contains (cert.Thumbprint));
if (!anyMatchingCerts) {
failures?.Add ($"The profile '{profile.Name}' ({profile.ApplicationIdentifier}) is not applicable because none of its developer certificates match the currently available certificates. This provisioning profile has {profile.DeveloperCertificates.Count} certificate(s):");
foreach (var cert in profile.DeveloperCertificates)
failures?.Add ($" {cert.Name} ({cert.Thumbprint})");
} else {
if (unique) {
int idx;

Expand All @@ -744,7 +744,6 @@ public static IList<MobileProvision> GetMobileProvisions (MobileProvisionPlatfor
var provision = MobileProvision.LoadFromFile (profile.FileName);
list.Add (provision);
}
break;
}
}

Expand Down