Add option to enable Linux cross builds for jit-format. #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when jit-format attempts to build a fresh version of compile-commands.json on Linux, it will always attempt a cross build, regardless of whether this is accurate for the host system. This patch adds an option to enable cross builds when on Linux, rather than defaulting to always building with -cross.
|
This bug is currently a little annoying as we (Arm) build everything on the target machines - we do no cross building at all. So, it's currently awkward to run the format checking test. |
|
@dotnet/jit-contrib |
|
I've written a fix that makes "--cross" a required parameter on platforms that need it (like is done here), and also fixed the CI system: I'm going to close this in favor of those PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when jit-format attempts to build a fresh version of compile-commands.json on Linux, it will always attempt a cross build, regardless of whether this is accurate for the host system. This currently breaks our internal formatting CI, as there is no way to disable this with an option/configuration flag.
This patch adds an option to enable cross builds when on Linux, rather than defaulting to always building with -cross.
I think this will likely break the current .NET CI though, as viewing the prior patch which introduced this argument indicates this was a quick fix to unblock CI after it moved to using rootfs on Mariner, requiring -cross. If this patch is applied,
--linux-crosswould have to be passed.