Skip to content

Fix duplicate owner in DartLab pipeline expansion - #20744

Merged
abonie merged 4 commits into
dotnet:mainfrom
abonie:fix-owner-dartlab
Oct 9, 2026
Merged

Fix duplicate owner in DartLab pipeline expansion#20744
abonie merged 4 commits into
dotnet:mainfrom
abonie:fix-owner-dartlab

Conversation

@abonie

@abonie abonie commented Oct 9, 2026

Copy link
Copy Markdown
Member

Description

Remove the duplicate templateContext.owner that prevents DartLab pipeline expansion. The production DartLab template already inserts the required top-level owner.

No associated issue. Verified the production insertion contract and reproduced the duplicate before the fix; the resulting context has unique keys and preserves the owner and area path. Live Azure DevOps pipeline preview was not run.

Checklist

  • Test cases added

  • Performance benchmarks added in case of performance changes

  • Release notes entry updated:

    Please make sure to add an entry with short succinct description of the change as well as link to this pull request to the respective release notes file, if applicable.

    Release notes files:

    • If anything under src/Compiler has been changed, please make sure to make an entry in docs/release-notes/.FSharp.Compiler.Service/<version>.md, where <version> is usually "highest" one, e.g. 42.8.200
    • If language feature was added (i.e. LanguageFeatures.fsi was changed), please add it to docs/release-notes/.Language/preview.md
    • If a change to FSharp.Core was made, please make sure to edit docs/release-notes/.FSharp.Core/<version>.md where version is "highest" one, e.g. 8.0.200.

    Information about the release notes entries format can be found in the documentation.
    Example:

    If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

No product behavior or performance changes; release notes and performance benchmarks are not applicable.

@abonie
Fix duplicate owner in DartLab pipeline expansion
0850862 
DartLab inserts the top-level owner into templateContext before expanding additional context properties.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 34f3e808-c404-4337-8e8c-76fcea75b3ed
@abonie
abonie requested a review from a team as a code owner October 9, 2026 08:25
@abonie abonie added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Oct 9, 2026
@abonie
abonie merged commit a274432 into dotnet:main Oct 9, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro approved these changes

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abonie @T-Gro