Fix checking nested fields for records #18964
Merged
+78
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tests, minor refactoring
❗ Release notes required
|
auduchinok
reviewed
Oct 3, 2025
tests/FSharp.Compiler.ComponentTests/Language/CopyAndUpdateTests.fs
Outdated
Show resolved
Hide resolved
tests/FSharp.Compiler.ComponentTests/Language/CopyAndUpdateTests.fs
Outdated
Show resolved
Hide resolved
|
I think this might also fix #18062 ? |
|
Yes, this fixes that issue too |
…x typo in func name.
T-Gro
approved these changes
Oct 13, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
kerams
reviewed
Oct 13, 2025
edgarfgp
reviewed
Oct 13, 2025
auto-merge was automatically disabled
October 14, 2025 14:57
Head branch was pushed to by a user without write access
|
/run fantomas |
🔧 CLI Command Report
✅ Patch applied: |
T-Gro
approved these changes
Oct 15, 2025
vzarytovskii
approved these changes
Oct 19, 2025
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the F# compiler’s type checker to correctly support and validate nested field updates (with depth > 1) for both anonymous and records. Add tests to cover these scenarios, and perform minor refactoring.
Fixes #18940
Fixes #18062