Sync from Azure DevOps: release/dev17.12 #18741
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update nuget handling in fsi release/dev17.12 ---- #### AI description (iteration 1) #### PR Classification New feature and enhancement. #### PR Summary This pull request updates the handling of NuGet packages in F# Interactive (FSI) and introduces new event handling for text views. - `Common/Extensions.fs`: Added `TextViewEventsHandler` and methods to handle text view events and caret positions. - `LanguageService/FSharpProjectOptionsManager.fs`: Enhanced project options management with new event subscriptions and caret position handling. - `Driver/ScriptClosure.fs`: Updated script closure processing to consider caret positions and package manager lines. - `FSharp.DependencyManager.Nuget/FSharp.DependencyManager.fs`: Added support for `usepackagetargets` option in NuGet package references. - `FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs`: Added tests for the new `usepackagetargets` option in script evaluation. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
de-loc ---- #### AI description (iteration 1) #### PR Classification Code cleanup #### PR Summary This pull request cleans up error handling and localization files by removing redundant translations and updating error messages. - `FSharp.DependencyManager.fs`: Replaced specific boolean error message with a more generic `ArgumentOutOfRangeException` message. - `FSDependencyManager.txt`: Removed the `invalidBooleanValue` error message. - `FSharpScriptTests.fs`: Updated test cases to reflect the new error message format. - Multiple localization files (`.xlf`): Removed the `invalidBooleanValue` translation entries. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
normalize format
…es. -release/dev17.12
#### AI description (iteration 1) #### PR Classification NuGet patch update and build configuration adjustments. #### PR Summary This pull request updates the NuGet package versions and adjusts build configurations to support internal source builds and dependencies. It ensures compatibility with the latest Microsoft Build version and adds new package sources. - `eng/build.sh`: Added no-operation implementations for runtime arguments used in internal builds. - `eng/SourceBuildPrebuiltBaseline.xml`: Added new usage entries for several Microsoft Build components and System.Formats.Asn1. - `azure-pipelines.yml`: Enabled internal sources for source builds. - `eng/Versions.props`: Updated `MicrosoftBuildVersion` to 17.12.36. - `NuGet.config`: Added a new package source for `msbuild-Trusted`. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
|
T-Gro
commented
Jul 9, 2025
abonie
approved these changes
Jul 9, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
T-Gro
added
the
NO_RELEASE_NOTES
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR syncs commits from the internal Azure DevOps mirror for branch 'release/dev17.12'. Please review and merge.