Handle active patterns with inferred function ty & unsolved range typar #18642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, for an active pattern whose type is known to be a function type but whose range type is not yet solved, assume that it _could_ be solved to, e.g., another function type. This can show up in, e.g., an active pattern that is defined mutually-recursively with `and`, has no type annotations, and returns a lambda with `fun` or `function`.
❗ Release notes required
|
edgarfgp
approved these changes
Jun 2, 2025
abonie
approved these changes
Jun 2, 2025
github-project-automation
bot
moved this from New
to In Progress
in F# Compiler and Tooling
github-project-automation
bot
moved this from In Progress
to Done
in F# Compiler and Tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18638, originally introduced in #16846 (I think?).
Treat
(|P|) : 'a -> 'bsimilarly to(|P|) : 'a.That is, for an active pattern whose type is known to be a function type but whose range type is not yet solved, assume that it could be solved to, e.g., another function type. This can show up in, e.g., an active pattern that is defined mutually-recursively with
and, has no type annotations, and returns a lambda withfunorfunction.Checklist