-
Notifications
You must be signed in to change notification settings - Fork 810
Fix resumable and non-resumable CE error ranges #18450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❗ Release notes required
|
Updated the baselines locally and all test are passing. But the CI is not reflecting the same. Any tips @psfinaki ? |
@edgarfgp yes :) I've checked out your branch. The thing is that you're most likely running tests locally in the Debug mode (where they indeed pass) whereas the CI executes them in Release mode (where they fail locally as well). You're nearly there! |
...syncExpressionStepping/AsyncExpressionSteppingTest3.fs.RealInternalSignatureOff.il.debug.bsl
Show resolved
Hide resolved
...formance/SpecialAttributesAndTypes/Imported/CallerInfo/CallerInfoAndComputationExpression.fs
Show resolved
Hide resolved
...syncExpressionStepping/AsyncExpressionSteppingTest3.fs.RealInternalSignatureOff.il.debug.bsl
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Thanks Edgar :)
Description
BEFORE
AFTER
Fixes #13789
Checklist