Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect AutoAdvance for GetTimestamp in FakeTimeProvider #5783

Merged

Conversation

amadeuszl
Copy link
Contributor

@amadeuszl amadeuszl commented Jan 9, 2025

Resolves #5694

Microsoft Reviewers: Open in CodeFlow

@amadeuszl amadeuszl requested a review from a team as a code owner January 9, 2025 09:19
@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 84.76 🔻

🎉 Good job! The coverage increased 🎉
Update MinCodeCoverage in the project files.

Project Expected Actual
Microsoft.Extensions.AI 88 89

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=911707&view=codecoverage-tab

@dotnet-comment-bot
Copy link
Collaborator

‼️ Found issues ‼️

Project Coverage Type Expected Actual
Microsoft.Extensions.Caching.Hybrid Line 86 77.82 🔻

Full code coverage report: https://dev.azure.com/dnceng-public/public/_build/results?buildId=911946&view=codecoverage-tab

@amadeuszl amadeuszl merged commit 045aaab into dotnet:main Jan 10, 2025
6 checks passed
@amadeuszl amadeuszl deleted the alechniak/add-autoadvance-for-gettimestamp branch January 10, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FakeTimeProvider does not advance when GetTimestamp is called
3 participants