fix: handle wildcard '*' in --context parameter for UpdateDatabase an…#38269
Open
BrunoSync wants to merge 2 commits into
Open
fix: handle wildcard '*' in --context parameter for UpdateDatabase an…#38269BrunoSync wants to merge 2 commits into
BrunoSync wants to merge 2 commits into
Conversation
…d MigrationsBundle
There was a problem hiding this comment.
Pull request overview
This PR adds wildcard --context * handling to migration database updates so EF Core tooling can attempt to update all discovered DbContext types.
Changes:
- Adds a wildcard branch in
MigrationsOperations.UpdateDatabase. - Adds a test intended to cover wildcard update behavior across multiple contexts.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/EFCore.Design/Design/Internal/MigrationsOperations.cs |
Adds CreateAllContexts() iteration for contextType == "*". |
test/EFCore.Design.Tests/Design/Internal/MigrationsOperationsTest.cs |
Adds wildcard update test coverage. |
Comment on lines
+223
to
+224
| var contexts = _contextOperations.CreateAllContexts(); | ||
| foreach (var item in contexts) |
| [ConditionalFact] | ||
| public void UpdateDatabase_with_wildcard_context_runs_for_all_contexts() | ||
| { | ||
| var assembly = MockAssembly.Create([typeof(AssemblyTestContext), typeof(TestContext)]); |
| using (item) | ||
| { | ||
| if (connectionString is not null) | ||
| item.Database.SetConnectionString(connectionString); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wildcard '*' support in --context parameter
Fixes #38254
What was done
UpdateDatabase— when--context *is passed, the operation now callsCreateAllContexts()and iterates over all found contextsMigrationsBundleis covered by this fix since it internally callsUpdateDatabaseUpdateDatabase_with_wildcard_context_runs_for_all_contextsto verify the fixPending
AddMigrationalso needs wildcard support, but since it returnsMigrationFiles, iterating over multiple contexts raises a design question about the return value. Looking for guidance on how to handle this before implementing.