Skip to content

Simplify SQL Server DROP DEFAULT CONSTRAINT migration query #38250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-x-shokhzod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify SQL Server DROP DEFAULT CONSTRAINT migration query #38250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions src/EFCore.SqlServer/Migrations/SqlServerMigrationsSqlGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2207,20 +2207,18 @@ protected virtual void DropDefaultConstraint(
builder
.Append("DECLARE ")
.Append(variable)
.AppendLine(" nvarchar(max);")
.AppendLine(" sysname;")
.Append("SELECT ")
.Append(variable)
.AppendLine(" = QUOTENAME([d].[name])")
.AppendLine("FROM [sys].[default_constraints] [d]")
.AppendLine(
"INNER JOIN [sys].[columns] [c] ON [d].[parent_column_id] = [c].[column_id] AND [d].[parent_object_id] = [c].[object_id]")
.Append("WHERE ([d].[parent_object_id] = OBJECT_ID(")
.AppendLine(" = QUOTENAME(OBJECT_NAME([c].[default_object_id]))")
.AppendLine("FROM [sys].[columns] [c]")
.Append("WHERE [c].[object_id] = OBJECT_ID(")
.Append(
stringTypeMapping.GenerateSqlLiteral(
Dependencies.SqlGenerationHelper.DelimitIdentifier(tableName, schema)))
.Append(") AND [c].[name] = ")
.Append(stringTypeMapping.GenerateSqlLiteral(columnName))
.AppendLine(");")
.AppendLine(";")
.Append("IF ")
.Append(variable)
.Append(" IS NOT NULL EXEC(")
Expand Down
36 changes: 16 additions & 20 deletions ...e.SqlServer.FunctionalTests/Migrations/MigrationsSqlServerTest.NamedDefaultConstraints.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,22 +193,20 @@ await Test(

AssertSql(
"""
DECLARE @var nvarchar(max);
SELECT @var = QUOTENAME([d].[name])
FROM [sys].[default_constraints] [d]
INNER JOIN [sys].[columns] [c] ON [d].[parent_column_id] = [c].[column_id] AND [d].[parent_object_id] = [c].[object_id]
WHERE ([d].[parent_object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Number');
DECLARE @var sysname;
SELECT @var = QUOTENAME(OBJECT_NAME([c].[default_object_id]))
FROM [sys].[columns] [c]
WHERE [c].[object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Number';
IF @var IS NOT NULL EXEC(N'ALTER TABLE [Entity] DROP CONSTRAINT ' + @var + ';');
ALTER TABLE [Entity] ALTER COLUMN [Number] int NOT NULL;
ALTER TABLE [Entity] ADD CONSTRAINT [MyConstraint] DEFAULT 7 FOR [Number];
""",
//
"""
DECLARE @var1 nvarchar(max);
SELECT @var1 = QUOTENAME([d].[name])
FROM [sys].[default_constraints] [d]
INNER JOIN [sys].[columns] [c] ON [d].[parent_column_id] = [c].[column_id] AND [d].[parent_object_id] = [c].[object_id]
WHERE ([d].[parent_object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Guid');
DECLARE @var1 sysname;
SELECT @var1 = QUOTENAME(OBJECT_NAME([c].[default_object_id]))
FROM [sys].[columns] [c]
WHERE [c].[object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Guid';
IF @var1 IS NOT NULL EXEC(N'ALTER TABLE [Entity] DROP CONSTRAINT ' + @var1 + ';');
ALTER TABLE [Entity] ALTER COLUMN [Guid] uniqueidentifier NOT NULL;
ALTER TABLE [Entity] ADD CONSTRAINT [MyConstraintSql] DEFAULT (NEWID()) FOR [Guid];
Expand Down Expand Up @@ -619,22 +617,20 @@ await Test(

AssertSql(
"""
DECLARE @var nvarchar(max);
SELECT @var = QUOTENAME([d].[name])
FROM [sys].[default_constraints] [d]
INNER JOIN [sys].[columns] [c] ON [d].[parent_column_id] = [c].[column_id] AND [d].[parent_object_id] = [c].[object_id]
WHERE ([d].[parent_object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Number');
DECLARE @var sysname;
SELECT @var = QUOTENAME(OBJECT_NAME([c].[default_object_id]))
FROM [sys].[columns] [c]
WHERE [c].[object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Number';
IF @var IS NOT NULL EXEC(N'ALTER TABLE [Entity] DROP CONSTRAINT ' + @var + ';');
ALTER TABLE [Entity] ALTER COLUMN [Number] int NOT NULL;
ALTER TABLE [Entity] ADD CONSTRAINT [DF_Entity_Number] DEFAULT 7 FOR [Number];
""",
//
"""
DECLARE @var1 nvarchar(max);
SELECT @var1 = QUOTENAME([d].[name])
FROM [sys].[default_constraints] [d]
INNER JOIN [sys].[columns] [c] ON [d].[parent_column_id] = [c].[column_id] AND [d].[parent_object_id] = [c].[object_id]
WHERE ([d].[parent_object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Guid');
DECLARE @var1 sysname;
SELECT @var1 = QUOTENAME(OBJECT_NAME([c].[default_object_id]))
FROM [sys].[columns] [c]
WHERE [c].[object_id] = OBJECT_ID(N'[Entity]') AND [c].[name] = N'Guid';
IF @var1 IS NOT NULL EXEC(N'ALTER TABLE [Entity] DROP CONSTRAINT ' + @var1 + ';');
ALTER TABLE [Entity] ALTER COLUMN [Guid] uniqueidentifier NOT NULL;
ALTER TABLE [Entity] ADD CONSTRAINT [DF_Entity_Guid] DEFAULT (NEWID()) FOR [Guid];
Expand Down
Loading
Loading