Skip to content

Remove EFCore.Analyzers.nuspec and use MSBuild packaging #37456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roji merged 1 commit into from
Jan 8, 2026
Merged

Remove EFCore.Analyzers.nuspec and use MSBuild packaging #37456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 9 additions & 15 deletions src/EFCore.Analyzers/EFCore.Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,18 @@
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyName>Microsoft.EntityFrameworkCore.Analyzers</AssemblyName>
<RootNamespace>Microsoft.EntityFrameworkCore</RootNamespace>
<IncludeBuildOutput>false</IncludeBuildOutput>
<NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile>

<!-- Causes the dll/pdb to be placed in the analyzers/dotnet/cs folder in the nupkg instead of lib -->
<BuildOutputTargetFolder>analyzers/dotnet/cs</BuildOutputTargetFolder>

<!-- A slightly hacky way to place the dll/pdbs directly under analyzers/dotnet/cs, and not under a netstandard2.0 subfolder -->
<IsTool>true</IsTool>

<IncludeSymbols>true</IncludeSymbols>
<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)..\..\rulesets\EFCore.noxmldocs.ruleset</CodeAnalysisRuleSet>
<ImplicitUsings>true</ImplicitUsings>
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
<PackageReadmeFile>README.md</PackageReadmeFile>
<NoWarn>$(NoWarn);NU5128</NoWarn>
<NoWarn>$(NoWarn);RS1038</NoWarn> <!-- Compiler extensions should be implemented in assemblies with compiler-provided references, #35752 -->
</PropertyGroup>
Expand All @@ -34,19 +41,6 @@
<PackageReference Update="NETStandard.Library" PrivateAssets="all" />
</ItemGroup>

<Target Name="SetPackageProperties" BeforeTargets="InitializeStandardNuspecProperties" DependsOnTargets="Build">
<PropertyGroup>
<!-- Make sure we create a symbols.nupkg. -->
<IncludeSymbols>true</IncludeSymbols>
</PropertyGroup>

<ItemGroup>
<NuspecProperty Include="targetFramework=$(TargetFramework)" />
<NuspecProperty Include="OutputBinary=$(OutputPath)$(AssemblyName).dll" />
<NuspecProperty Include="OutputSymbol=$(OutputPath)$(AssemblyName).pdb" />
</ItemGroup>
</Target>

<ItemGroup>
<AdditionalFiles Include="AnalyzerReleases.Shipped.md" />
<AdditionalFiles Include="AnalyzerReleases.Unshipped.md" />
Expand Down
18 changes: 0 additions & 18 deletions src/EFCore.Analyzers/EFCore.Analyzers.nuspec
View file
Open in desktop

This file was deleted.

0 src/EFCore.Analyzers/PACKAGE.md → src/EFCore.Analyzers/README.md
View file
Open in desktop
File renamed without changes.