add missing libnuma to Debian 11 packages #890
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
mthalman
reviewed
Jun 9, 2023
| @@ -48,7 +48,7 @@ RUN curl -LO https://packages.microsoft.com/keys/microsoft.asc && \ | |||
| rm microsoft.asc && \ | |||
| apt-add-repository https://packages.microsoft.com/debian/11/prod && \ | |||
| apt-get update && \ | |||
| apt-get install -y libmsquic && \ | |||
| apt-get install -y libnuma1 libmsquic && \ | |||
There was a problem hiding this comment.
Nit: I understand only two packages are here but might as well follow best practices right off the bat and have them listed alphabetically. My preference is to have them listed on separate lines as well. Same applies to other Dockerfiles.
Suggested change
| apt-get install -y libnuma1 libmsquic && \ | |
| apt-get install -y \ | |
| libmsquic \ | |
| libnuma1 && \ |
There was a problem hiding this comment.
I can do that. this will hopefully be reversed soon as msquic fixes their packages e.g. this should not really be needed.
ManickaP
approved these changes
Jun 9, 2023
|
closing in favor of 2.2.2 upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes dotnet/runtime#87275, workaround for microsoft/msquic#3421
related to dotnet/runtime#87181