Skip to content

Review summary of ActivitySource.StartActivity #9914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xml/System.Diagnostics/ActivitySource.xml
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ If the Activity object is created, it will not start automatically. Callers need
<Docs>
<param name="name">The operation name of the activity.</param>
<param name="kind">The activity kind.</param>
<summary>Creates a new activity if there are active listeners for it, using the specified name and activity kind.</summary>
<summary>Creates and starts a new activity if there are active listeners for it, using the specified name and activity kind.</summary>
<returns>The created activity object, if it had active listeners, or <see langword="null" /> if it has no event listeners.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -487,7 +487,7 @@ If the Activity object is created, it will not start automatically. Callers need
<param name="tags">The optional tags list to initialize the created activity object with.</param>
<param name="links">The optional <see cref="T:System.Diagnostics.ActivityLink" /> list to initialize the created activity object with.</param>
<param name="startTime">The optional start timestamp to set on the created activity object.</param>
<summary>Creates a new activity if there are active listeners for it, using the specified name, activity kind, parent activity context, tags, optional activity link and optional start time.</summary>
<summary>Creates and starts a new activity if there are active listeners for it, using the specified name, activity kind, parent activity context, tags, optional activity link and optional start time.</summary>
<returns>The created activity object, if it had active listeners, or <see langword="null" /> if it has no event listeners.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -538,7 +538,7 @@ If the Activity object is created, it will not start automatically. Callers need
<param name="tags">The optional tags list to initialize the created activity object with.</param>
<param name="links">The optional <see cref="T:System.Diagnostics.ActivityLink" /> list to initialize the created activity object with.</param>
<param name="startTime">The optional start timestamp to set on the created activity object.</param>
<summary>Creates a new activity if there are active listeners for it, using the specified name, activity kind, parent Id, tags, optional activity links and optional start time.</summary>
<summary>Creates and starts a new activity if there are active listeners for it, using the specified name, activity kind, parent Id, tags, optional activity links and optional start time.</summary>
<returns>The created activity object, if it had active listeners, or <see langword="null" /> if it has no event listeners.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down
Loading