Skip to content

Improved documentation for MemoryFailPoint when the constructor is called with value 0 #9544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2024

Conversation

vdekercd
Copy link
Contributor

@vdekercd vdekercd commented Jan 15, 2024

Summary

The documentation does not specify that an ArgumentOutOfRangeException is generated if the value is equal to 0.

Edit to add page: https://learn.microsoft.com/en-us/dotnet/api/system.runtime.memoryfailpoint.-ctor

@vdekercd vdekercd requested a review from a team as a code owner January 15, 2024 13:57
@ghost ghost added community-contribution Indicates that the PR has been added by a community member needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@vdekercd vdekercd changed the title Improved documentation when the constructor is called with value 0 Improved documentation for MemoryFailPoint when the constructor is called with value 0 Jan 15, 2024
@ghost
Copy link

ghost commented Jan 16, 2024

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

The documentation does not specify that an ArgumentOutOfRangeException is generated if the value is equal to 0.

Author: vdekercd
Assignees: -
Labels:

area-System.Memory, community-contribution, needs-area-label

Milestone: -

@vdekercd
Copy link
Contributor Author

@gewarren gewarren removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 15, 2024
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vdekercd

@gewarren gewarren closed this May 15, 2024
@gewarren gewarren reopened this May 15, 2024
@gewarren gewarren enabled auto-merge (squash) May 15, 2024 17:52
Copy link

Learn Build status updates of commit 526c09a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime/MemoryFailPoint.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit dc4190a into dotnet:main May 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants