Skip to content

Guidance for AggressiveInlining and AggressiveOptimization #9188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2023

Conversation

danmoseley
Copy link
Member

per comments in dotnet/runtime#90504

@learn-build-service-prod
Copy link

Learn Build status updates of commit 3c210b0:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Runtime.CompilerServices/MethodImplOptions.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Runtime.CompilerServices/MethodImplOptions.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: '<' is an unexpected token. The expected token is '>'. Line 155, position 572.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(String expectedToken1, String expectedToken2)
   at System.Xml.XmlTextReaderImpl.ThrowUnexpectedToken(Int32 pos, String expectedToken1, String expectedToken2)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@learn-build-service-prod
Copy link

Learn Build status updates of commit 9c4aafe:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/MethodImplOptions.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@danmoseley
Copy link
Member Author

@docs this should be ready

Co-authored-by: Genevieve Warren <[email protected]>
@learn-build-service-prod
Copy link

Learn Build status updates of commit 18db4ef:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Runtime.CompilerServices/MethodImplOptions.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@danmoseley danmoseley merged commit b151223 into dotnet:main Aug 15, 2023
@danmoseley danmoseley deleted the optimization branch August 15, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants