Merge branch 'master' into loc-release #4562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note to Dispose documentation to highlight that the `CancellationTokenSource` does not cancel its underlying `CancellationToken` when it is disposed, and that cancellation must be triggered separately.
* Updates to code owners Based on the latest updates to https://github.com/dotnet/runtime/blob/master/docs/area-owners.md * Update CODEOWNERS
* Auto port System.Threading ACL comments * Apply suggestions from code review Co-Authored-By: Koundinya Veluri <[email protected]> * Apply suggestions from code review Co-Authored-By: Koundinya Veluri <[email protected]> Co-authored-by: Koundinya Veluri <[email protected]>
* enable_try_dotnet_to_batch_5b * removed_extra_line * Update * Update * modified: * code_review_suggestions_applied Co-authored-by: Meenal Patel (CSI Interfusion Inc) <[email protected]>
* Replace legacy Code Gallery link with new Samples browser * Corrected link, using aka.ms to encapsulate query string. * Fix & usage
* enable_try_dotnet * updated_last_two_url
* Add missing docs for System.Collections[.Generic] * Add exceptions * Add System. prefix to exceptions * Address feedback - use tool to port exceptions
* Update ObjectSecurity.xml When you call the method SetAccessRuleProtection with both parameters on true, you may create a non-canonical DACL. I just made the most important changes. if you want to provide more details and e.g. code to "repair" the ACE order, I think this should go to a separate topic. I have a colleague who provided sample code. * Update xml/System.Security.AccessControl/ObjectSecurity.xml Co-Authored-By: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Security.AccessControl/ObjectSecurity.xml Co-authored-by: Jeremy Barton <[email protected]> Co-authored-by: Carlos Sanchez Lopez <[email protected]>
* Add undocumented APIs for S.Diagnostics.Process * Update xml/System.Diagnostics/Process.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/Process.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessThreadCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * Update xml/System.Diagnostics/ProcessModuleCollection.xml Co-authored-by: Carlos Sanchez Lopez <[email protected]> * add more docs Co-authored-by: Carlos Sanchez Lopez <[email protected]>
"Dataflow block*s* capture the state of the options at their construction."
* add cancelasync note * standardize notes; remove 'the' .net framework * add reco for httpclient
* replace linq queryable provider links Co-authored-by: Genevieve Warren <[email protected]>
* enable_try_dotnet_to_batch_7a * Update xml/System.Collections.Generic/ICollection`1.xml Co-authored-by: Maira Wenzel <[email protected]> * reverting_syntax * missing_interactive_2208_updated * Update xml/System.Collections.Generic/Dictionary`2.xml Co-authored-by: Maira Wenzel <[email protected]> Co-authored-by: Maira Wenzel <[email protected]>
The way of how Task.Run avoided indenting it's content and hiding the closing braces on the last Console.WriteLine line made it really hard to see what's going on here.
Should be zero instead of negative.
Removing System.Windows assembly for System.Windows.Resources.StreamResourceInfo
Corrected a typo
Changes hecxadecimal to hexadecimal.
* Update ArrayPool`1.xml Co-authored-by: Stephen Toub <[email protected]>
* MetadataReader: add remarks and example * Bump .NET Core version to support C# 8.0 Co-authored-by: Andy De George <[email protected]>
* Update DateTime.xml
* Add DispatcherTimer to the list of available timer classes
Typo "TextReader" should read "TextWriter"
* Link to unsafe-escaping section of how-to doc * Update xml/System.Text.Encodings.Web/JavaScriptEncoder.xml Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Youssef Victor <[email protected]>
* fix broken links * further fixes * fix note format * one more fix
Comment for the last example incorrectly stated the output of the test routine; it showed '' instead of 'null'
Co-authored-by: VSC-Service-Account <[email protected]>
The Remarks for the overload of `Insert` which takes a `CacheDependency` appears to have been copied and pasted from the overload which does not take that parameter and therefore stated that the object added to the cache would be inserted with "no file or cache dependencies", which of course is incorrect. This edit removes that text.
#3744) * Note interactive logon session behavior
The example is aiming to show a "non available" navigation service. The code should then behave as expected.
Add a remark that reading `ComboBox.Text` is dependent on whether there is a selected item or not.
Use the same wording as documentation for memmove C API. Fixes dotnet/runtime#6419 (comment)
Correctly reference UtcNow instead of Now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
87 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.