CI Update - Include Microsoft.Extensions.ServiceDiscovery#12836
Merged
Conversation
Build.Reason:Manual by Genevieve Warren Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=614692&view=results source_repo.branch:package-refresh-062926 source_repo.url:https://apidrop.visualstudio.com/_git/binaries
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the generated .NET API reference docs and metadata to include Microsoft.Extensions.ServiceDiscovery (and related Dns/Yarp components) across supported frameworks, alongside a few incidental formatting/metadata reshuffles from the refresh process.
Changes:
- Adds new API reference XML for
Microsoft.Extensions.ServiceDiscovery,Microsoft.Extensions.ServiceDiscovery.Dns, andMicrosoft.Extensions.ServiceDiscovery.Http(plus related DI extension types). - Adds/updates SourceLinkInformation entries for the new assemblies across
net-8.0-pp,net-9.0-pp,net-10.0-pp, andnet-11.0-pp. - Updates FrameworksIndex and PackageInformation to include the new assemblies/packages.
Reviewed changes
Copilot reviewed 63 out of 86 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Runtime.Serialization/XsdDataContractImporter.xml | Minor formatting adjustment in existing docs content. |
| xml/System.Net.Security/NegotiateAuthentication.xml | Small doc formatting change in a property’s <value> block. |
| xml/System.Linq/Queryable.xml | Regenerated parameter metadata ordering for net-11.0 alternate signatures. |
| xml/System.Linq/Enumerable.xml | Regenerated parameter metadata ordering for net-11.0 alternate signatures. |
| xml/System.Formats.Asn1/ValueAsnReader.xml | Regenerated altmember cross-reference ordering/targets. |
| xml/System.Formats.Asn1/AsnReader.xml | Regenerated altmember cross-reference ordering/targets. |
| xml/System.Formats.Asn1/AsnDecoder.xml | Regenerated altmember cross-reference ordering/targets. |
| xml/SourceLinkInformation/windowsdesktop-11.0/System.Private.Windows.GdiPlus.json | Updates SourceLink GUID and commit hash for an existing type. |
| xml/SourceLinkInformation/net-9.0-pp/Microsoft.Extensions.ServiceDiscovery.Yarp.json | Adds SourceLink mapping for ServiceDiscovery.Yarp assembly (net-9 preview pack). |
| xml/SourceLinkInformation/net-9.0-pp/Microsoft.Extensions.ServiceDiscovery.json | Adds SourceLink mapping for ServiceDiscovery assembly (net-9 preview pack). |
| xml/SourceLinkInformation/net-9.0-pp/Microsoft.Extensions.ServiceDiscovery.Dns.json | Adds SourceLink mapping for ServiceDiscovery.Dns assembly (net-9 preview pack). |
| xml/SourceLinkInformation/net-8.0-pp/Microsoft.Extensions.ServiceDiscovery.Yarp.json | Adds SourceLink mapping for ServiceDiscovery.Yarp assembly (net-8 preview pack). |
| xml/SourceLinkInformation/net-8.0-pp/Microsoft.Extensions.ServiceDiscovery.json | Adds SourceLink mapping for ServiceDiscovery assembly (net-8 preview pack). |
| xml/SourceLinkInformation/net-8.0-pp/Microsoft.Extensions.ServiceDiscovery.Dns.json | Adds SourceLink mapping for ServiceDiscovery.Dns assembly (net-8 preview pack). |
| xml/SourceLinkInformation/net-11.0-pp/Microsoft.Extensions.ServiceDiscovery.Yarp.json | Adds SourceLink mapping for ServiceDiscovery.Yarp assembly (net-11 preview pack). |
| xml/SourceLinkInformation/net-11.0-pp/Microsoft.Extensions.ServiceDiscovery.json | Adds SourceLink mapping for ServiceDiscovery assembly (net-11 preview pack). |
| xml/SourceLinkInformation/net-11.0-pp/Microsoft.Extensions.ServiceDiscovery.Dns.json | Adds SourceLink mapping for ServiceDiscovery.Dns assembly (net-11 preview pack). |
| xml/SourceLinkInformation/net-10.0-pp/Microsoft.Extensions.ServiceDiscovery.Yarp.json | Adds SourceLink mapping for ServiceDiscovery.Yarp assembly (net-10 preview pack). |
| xml/SourceLinkInformation/net-10.0-pp/Microsoft.Extensions.ServiceDiscovery.json | Adds SourceLink mapping for ServiceDiscovery assembly (net-10 preview pack). |
| xml/SourceLinkInformation/net-10.0-pp/Microsoft.Extensions.ServiceDiscovery.Dns.json | Adds SourceLink mapping for ServiceDiscovery.Dns assembly (net-10 preview pack). |
| xml/PackageInformation/net-9.0-pp.json | Adds the ServiceDiscovery package set to the net-9 preview package inventory. |
| xml/ns-Microsoft.Extensions.ServiceDiscovery.xml | Adds namespace stub doc for Microsoft.Extensions.ServiceDiscovery. |
| xml/ns-Microsoft.Extensions.ServiceDiscovery.Http.xml | Adds namespace stub doc for Microsoft.Extensions.ServiceDiscovery.Http. |
| xml/ns-Microsoft.Extensions.ServiceDiscovery.Dns.xml | Adds namespace stub doc for Microsoft.Extensions.ServiceDiscovery.Dns. |
| xml/Microsoft.Win32/Registry.xml | Formatting normalization for exception “-or-” blocks. |
| xml/Microsoft.Extensions.VectorData/VectorStore.xml | Minor altmember ordering change. |
| xml/Microsoft.Extensions.ServiceDiscovery/UriEndPoint.xml | Adds new API reference doc for UriEndPoint. |
| xml/Microsoft.Extensions.ServiceDiscovery/ServiceEndpointSource.xml | Adds new API reference doc for ServiceEndpointSource. |
| xml/Microsoft.Extensions.ServiceDiscovery/ServiceEndpointResolver.xml | Adds new API reference doc for ServiceEndpointResolver. |
| xml/Microsoft.Extensions.ServiceDiscovery/ServiceEndpointQuery.xml | Adds new API reference doc for ServiceEndpointQuery. |
| xml/Microsoft.Extensions.ServiceDiscovery/ServiceEndpoint.xml | Adds new API reference doc for ServiceEndpoint. |
| xml/Microsoft.Extensions.ServiceDiscovery/ServiceDiscoveryOptions.xml | Adds new API reference doc for ServiceDiscoveryOptions. |
| xml/Microsoft.Extensions.ServiceDiscovery/IServiceEndpointProviderFactory.xml | Adds new API reference doc for IServiceEndpointProviderFactory. |
| xml/Microsoft.Extensions.ServiceDiscovery/IServiceEndpointProvider.xml | Adds new API reference doc for IServiceEndpointProvider. |
| xml/Microsoft.Extensions.ServiceDiscovery/IServiceEndpointBuilder.xml | Adds new API reference doc for IServiceEndpointBuilder. |
| xml/Microsoft.Extensions.ServiceDiscovery/IHostNameFeature.xml | Adds new API reference doc for IHostNameFeature. |
| xml/Microsoft.Extensions.ServiceDiscovery/ConfigurationServiceEndpointProviderOptions.xml | Adds new API reference doc for ConfigurationServiceEndpointProviderOptions. |
| xml/Microsoft.Extensions.ServiceDiscovery.Http/IServiceDiscoveryHttpMessageHandlerFactory.xml | Adds new API reference doc for IServiceDiscoveryHttpMessageHandlerFactory. |
| xml/Microsoft.Extensions.ServiceDiscovery.Dns/DnsServiceEndpointProviderOptions.xml | Adds new API reference doc for DnsServiceEndpointProviderOptions. |
| xml/Microsoft.Extensions.ServiceDiscovery.Dns/DnsResolverOptions.xml | Adds new API reference doc for DnsResolverOptions. |
| xml/Microsoft.Extensions.DependencyInjection/ServiceDiscoveryReverseProxyServiceCollectionExtensions.xml | Adds DI extensions for Yarp reverse proxy integration. |
| xml/Microsoft.Extensions.DependencyInjection/ServiceDiscoveryHttpClientBuilderExtensions.xml | Adds DI extensions for IHttpClientBuilder integration. |
| xml/Microsoft.Extensions.DependencyInjection/FromKeyedServicesAttribute.xml | Minor altmember ordering change. |
| xml/FrameworksIndex/netstandard-2.0-pp.xml | Adds ServiceDiscovery assemblies/types to the netstandard index. |
| xml/FrameworksIndex/netframework-4.8.1-pp.xml | Adds ServiceDiscovery assemblies/types to the net48.1 index. |
| xml/FrameworksIndex/netframework-4.8-pp.xml | Adds ServiceDiscovery assemblies/types to the net48 index. |
| xml/FrameworksIndex/netframework-4.7.2-pp.xml | Adds ServiceDiscovery assemblies/types to the net472 index. |
| xml/FrameworksIndex/netframework-4.7.1-pp.xml | Adds ServiceDiscovery assemblies/types to the net471 index. |
| xml/FrameworksIndex/netframework-4.7-pp.xml | Adds ServiceDiscovery assemblies/types to the net47 index. |
| xml/FrameworksIndex/netframework-4.6.2-pp.xml | Adds ServiceDiscovery assemblies/types to the net462 index. |
Comment on lines
+291
to
+292
| <value> | ||
| <see langword="true" /> if the authentication exchange has completed; otherwise, <see langword="false" />.</value> |
| <Interfaces /> | ||
| <Docs> | ||
| <summary> | ||
| Builder to create a <see cref="T:Microsoft.Extensions.ServiceDiscovery.ServiceEndpointSource" /> instances. |
Comment on lines
+42
to
+43
| Creates an <see cref="T:System.Net.Http.HttpMessageHandler" /> instance which resolve endpoints using service discovery before | ||
| delegating to a provided handler. |
| </Attributes> | ||
| <Docs> | ||
| <summary> | ||
| Options for <see cref="T:Microsoft.Extensions.ServiceDiscovery.Configuration.ConfigurationServiceEndpointProvider" />. |
| </Attributes> | ||
| <Docs> | ||
| <summary> | ||
| Options for configuring <see cref="T:Microsoft.Extensions.ServiceDiscovery.Dns.DnsServiceEndpointProvider" />. |
| <Docs> | ||
| <param name="services">To be added.</param> | ||
| <summary> | ||
| Adds the <see cref="T:Yarp.ReverseProxy.Forwarder.IHttpForwarder" /> with service discovery support. |
| <Docs> | ||
| <param name="builder">To be added.</param> | ||
| <summary> | ||
| Provides a <see cref="T:Yarp.ReverseProxy.ServiceDiscovery.IDestinationResolver" /> implementation which uses service discovery to resolve destinations. |
| <Docs> | ||
| <param name="services">To be added.</param> | ||
| <summary> | ||
| Provides a <see cref="T:Yarp.ReverseProxy.Forwarder.IForwarderHttpClientFactory" /> implementation which uses service discovery to resolve service names. |
Collaborator
Author
|
I'll fix the suggestions in the dotnet/extensions repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build.Reason:Manual by Genevieve Warren
Build.Url:https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=614692&view=results
source_repo.branch:package-refresh-062926
source_repo.url:https://apidrop.visualstudio.com/_git/binaries