Skip to content

Add MemberGroup descriptions (remainder)#12822

Draft
gewarren wants to merge 2 commits into
dotnet:mainfrom
gewarren:membergroup-set14
Draft

Add MemberGroup descriptions (remainder)#12822
gewarren wants to merge 2 commits into
dotnet:mainfrom
gewarren:membergroup-set14

Conversation

@gewarren

Copy link
Copy Markdown
Collaborator

Contributes to #12626.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR continues the effort in #12626 by adding missing <MemberGroup> documentation so overload sets (constructors and methods) have a shared, group-level summary in the ECMA XML reference files.

Changes:

  • Add constructor (.ctor) <MemberGroup> summaries to several System.ServiceModel* and Microsoft.Win32.SafeHandles* type docs.
  • Add <MemberGroup> summaries for overload sets in ClientBase\1 (ICommunicationObject.Close/Open) and RegistryAclExtensions (GetAccessControl`).
  • Add an overload-group <MemberGroup> for AsOpenAIResponseTool (needs a small wording correction to cover all overloads).

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
xml/System.ServiceModel/UnixDomainSocketBinding.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel/ClientBase`1.xml Adds MemberGroup summaries for explicit ICommunicationObject.Close/Open overload sets.
xml/System.ServiceModel.Federation/WSTrustTokenParameters.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Federation/WSTrustChannelFactory.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Federation/WSTrustChannelClientCredentials.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Channels/UnixPosixIdentityBindingElement.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Channels/UnixDomainSocketTransportBindingElement.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Channels/TransportBindingElement.xml Adds .ctor MemberGroup summary for constructors.
xml/System.ServiceModel.Channels/ConnectionOrientedTransportBindingElement.xml Adds .ctor MemberGroup summary for constructors.
xml/OpenAI.Responses/MicrosoftExtensionsAIResponsesExtensions.xml Adds MemberGroup summary for AsOpenAIResponseTool overload set (currently too narrow for all overloads).
xml/Microsoft.Win32/RegistryAclExtensions.xml Adds MemberGroup summary for GetAccessControl overload set.
xml/Microsoft.Win32.SafeHandles/SafeWaitHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeRegistryHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeProcessHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafePipeHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeFileHandle.xml Adds .ctor MemberGroup summary for constructors.
xml/Microsoft.Win32.SafeHandles/SafeAccessTokenHandle.xml Adds .ctor MemberGroup summary for constructors.

Comment thread xml/OpenAI.Responses/MicrosoftExtensionsAIResponsesExtensions.xml
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants