Skip to content

Remove needs-area-label when area label added #11335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Remove needs-area-label when area label added #11335

merged 1 commit into from
May 23, 2025

Conversation

gewarren
Copy link
Contributor

No description provided.

@gewarren gewarren requested a review from a team as a code owner May 22, 2025 23:20
@gewarren gewarren enabled auto-merge (squash) May 22, 2025 23:20
BillWagner
BillWagner approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this.

We should make a feature request for the label tag to support regex or glob style patterns. This would be so much simpler if we could have one tag:

-labelAdded:
    label: `area-.*`

@gewarren gewarren merged commit 8126dc5 into main May 23, 2025
7 checks passed
@gewarren gewarren deleted the gewarren-patch-5 branch May 23, 2025 13:21
@gewarren
Copy link
Contributor Author

It's working!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees

@gewarren gewarren

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gewarren @BillWagner