Skip to content

Add language reference and fundamentals for C# 14 extension members #45654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 18, 2025

Conversation

@BillWagner BillWagner force-pushed the extensions-language-reference branch from 0559e78 to edbc583 Compare April 17, 2025 20:44
@BillWagner BillWagner marked this pull request as ready for review April 17, 2025 21:26
@BillWagner BillWagner requested review from IEvangelist, a team and CamSoper as code owners April 17, 2025 21:26
Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @BillWagner!

My only comment is that naming the extension method .Add() did confuse me for a second because you intended it as "Add an item to this IEnumerable<int>" and not "Do some kind of mathematical operation on this IEnumerable<int>". But it only took me a second to realize my mistake so maybe it's not worth fixing? IDK.

@BillWagner BillWagner closed this Apr 18, 2025
@BillWagner BillWagner reopened this Apr 18, 2025
@BillWagner BillWagner merged commit 449b881 into dotnet:main Apr 18, 2025
15 checks passed
@BillWagner BillWagner deleted the extensions-language-reference branch April 18, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants