-
Notifications
You must be signed in to change notification settings - Fork 6k
Provide "static virtual interface members" with examples and description of static virtual
methods
#43130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BartoszKlonowski
wants to merge
6
commits into
dotnet:main
Choose a base branch
from
BartoszKlonowski:feature/41668/static-virtual
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−0
Open
Provide "static virtual interface members" with examples and description of static virtual
methods
#43130
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f2c5afc
Implement entities showing static virtual in interface
BartoszKlonowski 0fd0790
Utilize the static virtual methods defining in TestDuplication example
BartoszKlonowski 6929ea6
Describe in details the static virtual methods of an interface
BartoszKlonowski 51c71a6
Reimplement the example of static virtual to present the Singleton ap…
BartoszKlonowski f0c613d
Rephrase the description to mention ISingleton and rephrase the entry
BartoszKlonowski 69a3f65
Cast UniqueInstance to ISingleton to access Instance
BartoszKlonowski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
docs/csharp/whats-new/tutorials/snippets/staticinterfaces/Singleton.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
public interface ISingleton<T> where T : new() | ||
{ | ||
public static virtual T Instance | ||
{ | ||
get | ||
{ | ||
field ??= new T(); | ||
return field; | ||
} | ||
private set | ||
{ | ||
field = value; | ||
} | ||
} | ||
} |
7 changes: 7 additions & 0 deletions
7
docs/csharp/whats-new/tutorials/snippets/staticinterfaces/UniqueInstance.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
public class UniqueInstance : ISingleton<UniqueInstance> | ||
{ | ||
public void PrintMessage() | ||
{ | ||
Console.WriteLine("This is a unique instance"); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this to work, you'll need to use the interface type:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillWagner I committed this suggestion, although locally, with VS still on version 17.4 I do have issues with your suggestion: CS0119 for UniqueInstance and CS0305 for ISingleton (which can be fixed by specifying the T type for this cast).
Let's see if remotely it will also fail and then we can check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BillWagner I should mention, that locally, with VS v17.4 I can also see the initial error for
Instance
not being a part ofUniqueInstance
.Somewhere I read that
static virtual
feature requires:staticinterfaces
project runs on .NET 8, which should be fine?LangVersion
- we have that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BartoszKlonowski
I see the new errors. To answer your question:
Yes, it should be. As a normal practice, we're happy to move to the latest GA release (.NET 9 now).
Check.
We should be using the .NET 10 preview build (because some of the docs are for the preview).
Now, this example might be tricky to get right unless the type overrides the interface method (even if it just calls the interface implementation.) Why? Well, an
ISingleton<int>
could be implemented by more than one class type. So, which one should be used? Without an instance of the type, that's hard to express.