Refactor CopyAcrImagesCommand to utilize ACR library vs AZ CLI #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #165
Refactored the CopyAcrImagesCommand to use the Azure Fluent library instead of invoking the AZ CLI via a Docker container. This is significantly faster as the web requests are invokes asynchronously. On my machine it takes less than one min to publish 282 images (dotnet-docker).
There are a few issues that I needed to workaround in the code.
ImportAzure/azure-libraries-for-net#656As a result of these optimizations, it is no longer necessary to distribute the copy legs of builds across multiple machines therefore the PlatformVersionedOs MatrixType was removed.