Allow non-numeric warnings in #pragma #359
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings in
#pragma warning disablecan be non-numeric (and I think can be any alphanumeric value for source analyzers, doesn't even just start with alphabetic and then ends with numeric). I've updated the regex to support this, and also tweak it so that it supports >2 warnings at once. I've kept it asconstant.numeric.decimal.cs, but might be good for this to be changed also? Maybeconstant.other.warning-id.cs? Something else entirely?I encounter this issue a lot, and had thought it was something to do with comments after
#pragma, so that's why there are a few tests that check that this works.Demo: