Fix primary constructor base class argument tokenization #351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix primary constructor with base class constructor arguments
base-typespattern's#typeincludestuple-typewhich consumes parenthesesbase-class-constructor-callpattern to handle type name followed by argument listbase-typespattern to use new pattern before general#typepatternSummary
Fixed the issue where primary constructors with base class constructor arguments were not being properly classified. The problem occurred when a class or record with a primary constructor called a base class constructor with arguments, especially lambda expressions.
Examples Fixed
Technical Details
Created a new
base-class-constructor-callpattern that matches type names (including generic and qualified names) followed by argument lists. This pattern is included before the general#typepattern in thebase-typescontext, preventing thetuple-typepattern from incorrectly consuming the argument list parentheses.Tests
Added 12 new tests in
constructor.tests.tscovering:Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.