Skip to content

Update test projects to use "net8.0" as a moniker for testing #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 19, 2025

Conversation

zbalkan
Copy link
Contributor

@zbalkan zbalkan commented Jun 5, 2025

Since .NET 7.0 EOL, it's better to stick to LTS version that is till supported. I used LTS instead of LTS to minimize friction between new versions.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffhandley @adamsitnik I think it would be good to consider this change for the next possible nuget.org release.

@zbalkan
Copy link
Contributor Author

zbalkan commented Jun 18, 2025

5 commits for this small change may look a bit messy. Should I squash and force-push or do you prefer a merge with squash after it is approved?

@jonsequitur
Copy link
Contributor

Other than the package version change for System.Memory, these changes only affect tests. The System.CommandLine library already targets net8.0 and netstandard2.0.

@ViktorHofer
Copy link
Member

ViktorHofer commented Jun 18, 2025

Right but we shouldn't be depending on old / obsolete package dependencies, specifically System.Memory/4.5.4 and Newtonsoft.Json/13.0.2 in upcoming releases.

@ViktorHofer ViktorHofer merged commit 38414ef into dotnet:main Jun 19, 2025
10 checks passed
@Frulfump
Copy link

Frulfump commented Jul 23, 2025

From PR description

LTS instead of LTS

?!
PR title is a bit confusing since the focus is the .NET version used in tests, and the other changes bump some packages not necessarily tied to .NET 8? And it show up as just that in the GitHub release description.

@adamsitnik adamsitnik changed the title Update to .NET 8.0 Update test projects to use "net8.0" as a moniker for testing Jul 24, 2025
@adamsitnik
Copy link
Member

From PR description

LTS instead of LTS

?! PR title is a bit confusing since the focus is the .NET version used in tests, and the other changes bump some packages not necessarily tied to .NET 8? And it show up as just that in the GitHub release description.

Good point, I've renamed it to "Update test projects to use "net8.0" as a moniker for testing "

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants