Add support for CosmosDB vnext-preview emulator #7048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new experimental API - RunAsPreviewEmulator. This will use the new Linux-based emulator, which starts faster. And it also has support for a built-in Data Explorer which can be enabled by calling WithDataExplorer on the emulator. Fix dotnet#5163
eerhardt
requested review from
davidfowl,
Pilchie,
mitchdenny,
sebastienros and
Copilot
There was a problem hiding this comment.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/Aspire.Hosting.Azure.CosmosDB/PublicAPI.Shipped.txt: Language not supported
- src/Aspire.Hosting.Azure.CosmosDB/PublicAPI.Unshipped.txt: Language not supported
- src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBEmulatorConnectionString.cs: Evaluated as low risk
- src/Aspire.Hosting.Azure.CosmosDB/AzureCosmosDBEmulatorResource.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
playground/CosmosEndToEnd/CosmosEndToEnd.ApiService/Program.cs:23
- The partition key path was changed from
/Idto/id. If the partition key is case-sensitive, this change could lead to unexpected behavior or errors.
var container = (await db.CreateContainerIfNotExistsAsync("entries", "/id")).Container;
Pilchie
approved these changes
Jan 9, 2025
|
Also tagging @christopheranderson |
joperezr
reviewed
Jan 9, 2025
joperezr
reviewed
Jan 9, 2025
davidfowl
reviewed
Jan 9, 2025
| /// </remarks> | ||
| public static IResourceBuilder<AzureCosmosDBEmulatorResource> WithDataExplorer(this IResourceBuilder<AzureCosmosDBEmulatorResource> builder, int? port = null) | ||
| { | ||
| if (!builder.Resource.InnerResource.IsPreviewEmulator) |
There was a problem hiding this comment.
Because it doesn't work in the latest emulator. See Azure/azure-cosmos-db-emulator-docker#135.
Also fixing the EF CosmosDB code to specify the PartitionKey.
This was referenced Jan 9, 2025
|
@Pilchie @christopheranderson - it looks like the vnext-preview emulator is failing to start in CI sometimes: Have you ever seen this error before? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new experimental API - RunAsPreviewEmulator. This will use the new Linux-based emulator, which starts faster. And it also has support for a built-in Data Explorer which can be enabled by calling WithDataExplorer on the emulator.
Fix #5163
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):