Load framework data from dump pack manifest#162
Open
syrle-foronda wants to merge 2 commits into
Open
Conversation
Teach DumpPacks to emit a structured JSON manifest for built-in packs, workload packs, supported platform versions, and collected warnings/errors instead of only writing console output. Update framework generation to read that manifest, append framework definitions for newer TFMs, and infer pack/platform metadata from the dumped SDK and workload data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the
DumpPackstool, focusing on structured JSON output, improved diagnostics, and CI pipeline integration. The changes replace previous console output with a manifest-based approach, capturing both built-in and workload packs, their versions, and any encountered errors or warnings. Additionally, the Azure pipeline is updated to build and run the newDumpPackstool using .NET 11 SDK.Key changes:
Manifest-based JSON output and models
Program.cswith a structuredDumpPackManifestobject, aggregating built-in packs, workload packs, platform versions, and errors, and outputting the result as formatted JSON (SetJsonString) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10].Centralized diagnostics reporting
DumpPackDiagnosticsfor collecting errors and warnings throughout the process, replacing directConsole.WriteLinecalls in multiple files; all collected messages are included in the final manifest output [1] [2] [3] [4] [5] [6] [7].Azure pipeline integration
gen-catalog.ymlpipeline to build and publish theDumpPackstool and include its source path in triggers [1] [2].DumpPacks, capturing its output as JSON [1] [2] [3].Minor improvements
using System.Text.Json;inFrameworkDefinition.All.csto support JSON serialization.These changes make
DumpPacksmore robust, testable, and suitable for automation, while also improving error visibility and future extensibility.Teach DumpPacks to emit a structured JSON manifest for built-in packs, workload packs, supported platform versions, and collected warnings/errors instead of only writing console output. Update framework generation to read that manifest, append framework definitions for newer TFMs, and infer pack/platform metadata from the dumped SDK and workload data.