Try to preserve the app cache on uninstall. #10019
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make |
the |
note that the very first call to |
There was a problem hiding this comment.
I was looking what "fast deployment" does for this in Debug mode, and I can only find the pm command:
Should we only use the pm command here instead of trying two commands? Just to make Debug & Release consistent?
We can also update this target, which is maybe not used:
android/src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets
Lines 3017 to 3030 in 747041d
So just use the |
|
You might review what |
Context #9259 Due to various reasons `adb` may not be able to preserve the app cache on uninstall. To work around this we have to use the `-k` flag to uninstall the app when using the `cmd package uninstall` call. This will keep the app data and cache on the device. However this might also fail. So in that case we need to completely uninstall the app and then install it again.
dellis1972
force-pushed
the
dev/dellis1972/Issue9259
branch
from
253bf0a to
34f59f6
Compare
|
@jonathanpeppers I went with just calling |
jonathanpeppers
approved these changes
Apr 28, 2025
|
@jonathanpeppers looks like it broke a re-install aab test though |
jonpryor
reviewed
May 5, 2025
| <AndroidAdb | ||
| Condition=" '$(EmbedAssembliesIntoApk)' == 'true' " | ||
| ContinueOnError="True" | ||
| ToolExe="$(AdbToolExe)" | ||
| ToolPath="$(AdbToolPath)" | ||
| AdbTarget="$(AdbTarget)" | ||
| Command="uninstall" | ||
| Arguments="-k $(_AndroidPackage)" | ||
| Command="shell cmd package uninstall -k" |
There was a problem hiding this comment.
I wonder if this should instead be adb shell pm uninstall -k PACKAGE.
There was a problem hiding this comment.
…as I'd never heard of adb shell cmd before now, and it's not listed at e.g. <adbshell.com>.
There was a problem hiding this comment.
I didn't notice it's doing adb shell cmd package uninstall -k.
android-platform-support looked like it was doing adb shell pm uninstall -k, so let me just change to that and let's see what CI says?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Ok, there is one test failure in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #9259
Due to various reasons
adbmay not be able to preserve the app cache on uninstall. To work around this we have to use the-kflag to uninstall the app when using thecmd package uninstallcall. This will keep the app data and cache on the device.However this might also fail. So in that case we need to completely uninstall the app and then install it again.
Summary
This pull request updates the
_DeployAppBundletarget inXamarin.Android.Common.targetsto improve the handling of app uninstallation during deployment when using Android App Bundles (aab). The changes ensure better compatibility withadbcommands and handle scenarios where cached data needs to be preserved or removed.AndroidAdbtask to useshell pm uninstall -kinstead ofuninstallfor preserving cached data during app uninstallation. This aligns with the correctadbcommand syntax.