Initial switch to the Toolkit Adorners package... #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some issues with the editor adorner, also removing adorners (like switching out of modify mode) Issue with negative margin on Surrounding Adorner (not sure if that worked before anyway) But pretty close...
michael-hawker
added
enhancement
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some issues with the editor adorner, also removing adorners (like switching out of modify mode) Issue with negative margin on Surrounding Adorner (not sure if that worked before anyway) But pretty close...
Need to decide if there's thing to improve in the base Adorners, but also clean-up how they're used a bit within XAML Studio.
There's a bit more pros/cons to the simplicity I had here before, but extracting and making them more robust was certainly the right call for WCT Labs. We also shored up issues there with responding to resizing which was needed.
History: The Adorners originally started in WCT Labs, then I brought them in here to work on editor features, we then initially solved the resize problem, so we exported them back to WCT Labs to finalize as a feature and have a proper base class. This is the final round-trip to leverage them from the WCT Labs package instead of relying on this older shadow-copy.