Add missing package reference to System.Data.Common#4063
Add missing package reference to System.Data.Common#4063cheenamalhotra wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an explicit System.Data.Common dependency to the SqlClient build and packaging metadata so the net462 target has a direct/declared reference instead of relying on implicit or transitive resolution.
Changes:
- Add
System.Data.Commonas aPackageReferencefor the net462 build ofMicrosoft.Data.SqlClient. - Add
System.Data.Commonto the netfx reference-assembly project’s package references. - Pin
System.Data.Commoncentrally and declare it as a net462 dependency in the.nuspec.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/specs/Microsoft.Data.SqlClient.nuspec | Declares System.Data.Common (4.3.0) as a net462 NuGet dependency. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Adds System.Data.Common package reference for the net462 target. |
| src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj | Adds System.Data.Common package reference for the net462 reference assembly build. |
| Directory.Packages.props | Centrally pins System.Data.Common to 4.3.0. |
You can also share your feedback on Copilot code review. Take the survey.
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #4063 +/- ##
==========================================
- Coverage 75.42% 68.11% -7.31%
==========================================
Files 280 275 -5
Lines 43834 66924 +23090
==========================================
+ Hits 33060 45588 +12528
- Misses 10774 21336 +10562
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.