Change AKV Provider to target .NET Standard 2.0 by paulmedynski · Pull Request #4016 · dotnet/SqlClient

paulmedynski · 2026-03-06T15:52:08Z

Description

This PR changes the AKV Provider to target .NET Standard 2.0 since it doesn't contain any code specific to .NET or .NET Framework. Changes include:

AKV Provider Changes:
- Explicitly set <TargetFramework> to netstandard2.0 in the AKV Provider project.
- Removed the add-ons/Directory.Build.props.
- Absorbed the AKV Provider nuspec into the csproj.
Build Changes:
- Added new BuildAkvProvider and PackAkvProvider targets to build.proj.
- Removed all of the obsolete AKV Provider build targets.
- Removed the GenerateAkvPackage target and all references to it.
- Added BuildAllPackages and PackAllPackages targets.
- Added BuildSqlClient and PackSqlClient targets to help fix the Docs-Build-Pack-Publish pipeline.
Pipeline Changes:
- Updated pipelines to pack the AKV Provider directly.

Testing

Automated PR runs will confirm basic functionality.
- ✅ PR-SqlClient-Project - Run 06802
- ✅ PR-SqlClient-Package - Run 06802
Manual CI run will confirm those pipeline changes.
- 🟨 CI-SqlClient - Run 07005
- 🟨 CI-SqlClient-Package - Run 07005
Manual OneBranch pipeline runs will confirm official builds.
- ✅ sqlclient-non-official - Run 26068.3
Maunal runs of the Docs-Build-Pack-Publish pipeline to confirm fixes there:
- ✅ Docs-Build-Pack-Publish - Run 26066.3
✅ Verified NuGet metadata via the verify script.

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

eng/pipelines/onebranch/jobs/build-akv-official-job.yml

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj

tools/specs/Microsoft.Data.SqlClient.nuspec

build.proj

Copilot

Pull request overview

This PR updates the Always Encrypted Azure Key Vault (AKV) Provider to target .NET Standard 2.0 and modernizes its packaging flow by moving from a standalone .nuspec/custom MSBuild target to SDK-style dotnet pack driven by the AKV Provider .csproj. It also updates build/pipeline wiring to use the new BuildAkvProvider/PackAkvProvider targets.

Changes:

Removed the legacy AKV .nuspec and GenerateAkvPackage MSBuild target infrastructure.
Updated the AKV Provider project to netstandard2.0 and embedded NuGet metadata into the .csproj.
Updated build and pipeline steps to build/pack the AKV Provider directly via dotnet pack and new build.proj targets.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tools/targets/add-ons/GenerateAkvPackage.targets	Removes the legacy `GenerateAkvPackage` target.
tools/specs/add-ons/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.nuspec	Deletes the old AKV Provider `.nuspec` (packaging now via `.csproj`).
tools/specs/Microsoft.Data.SqlClient.nuspec	Adds a header comment documenting required `nuget pack` properties (contains a small typo).
src/Microsoft.Data.SqlClient/add-ons/Directory.Build.props	Removes add-ons-specific props file (AKV now uses standard props chain).
src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj	Sets `netstandard2.0` and absorbs NuGet package metadata/config into the project.
eng/pipelines/onebranch/variables/common-variables.yml	Removes `akvNuspecPath` variable (no longer applicable).
eng/pipelines/onebranch/steps/roslyn-analyzers-akv-step.yml	Updates build target from `BuildAkv` to `BuildAkvProvider`.
eng/pipelines/onebranch/steps/compound-build-akv-step.yml	Updates build target naming/usage to `BuildAkvProvider`.
eng/pipelines/onebranch/jobs/build-akv-official-job.yml	Switches AKV packaging step from nuspec-based to `dotnet pack` on the `.csproj`.
eng/pipelines/common/templates/steps/ci-project-build-step.yml	Replaces old AKV build targets with `BuildAkvProvider` (but introduces a Windows gating issue).
eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml	Switches AKV packaging from nuspec-based step to `dotnet pack` on the `.csproj`.
build.proj	Removes `GenerateAkvPackage.targets` import; adds `BuildAkvProvider`/`PackAkvProvider`; updates BuildSqlClient deps.
BUILDGUIDE.md	Documents the new `BuildAkvProvider`/`PackAkvProvider` targets and removes obsolete AKV targets.

Comments suppressed due to low confidence (1)

src/Microsoft.Data.SqlClient/add-ons/AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj:78

Switching AKV Provider packaging from a nuspec to SDK-style dotnet pack means the project’s PackageReferences/ProjectReferences now flow into the produced NuGet dependency graph. This project currently references Microsoft.Data.SqlClient.Extensions.Logging, which the removed nuspec did not list, so this change will add/alter external package dependencies for consumers. If the AKV provider doesn’t actually use Logging APIs, remove that reference or mark it as PrivateAssets=all to avoid changing the published dependency set.

  <!-- References ====================================================== -->
  <!-- MDS Reference -->
  <ItemGroup>
    <ProjectReference Include="$(RepoRoot)/src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj"
                      Condition="'$(ReferenceType)' != 'Package'" />
    <PackageReference Include="Microsoft.Data.SqlClient"
                      Condition="'$(ReferenceType)' == 'Package'" />
  </ItemGroup>

You can also share your feedback on Copilot code review. Take the survey.

eng/pipelines/common/templates/steps/ci-project-build-step.yml

tools/specs/Microsoft.Data.SqlClient.nuspec

BUILDGUIDE.md

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

tools/props/Versions.props

tools/specs/Microsoft.Data.SqlClient.nuspec

BUILDGUIDE.md

codecov · 2026-03-06T20:45:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.36%. Comparing base (326a242) to head (467ec7d).
⚠️ Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (326a242) and HEAD (467ec7d). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (326a242) HEAD (467ec7d)

CI-SqlClient 1 0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4016      +/-   ##
==========================================
- Coverage   72.65%   65.36%   -7.29%     
==========================================
  Files         287      275      -12     
  Lines       43134    65809   +22675     
==========================================
+ Hits        31337    43017   +11680     
- Misses      11797    22792   +10995

Flag	Coverage Δ
CI-SqlClient	`?`
PR-SqlClient-Project	`65.36% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tools/targets/GenerateMdsPackage.targets

Copilot

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

build.proj

tools/targets/GenerateMdsPackage.targets

Copilot

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj

build.proj

tools/targets/GenerateMdsPackage.targets

build.proj

Copilot

Pull request overview

Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

BUILDGUIDE.md

eng/pipelines/onebranch/steps/build-all-configurations-signed-dlls-step.yml

Directory.Packages.props

Copilot

Pull request overview

Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

Directory.Packages.props

…y to inhibit NuGet.exe download when generating SqlClient package.

…e to use.

- Fixed CI package build flow MDS build steps.

…d removed the obsolete AKV-specific templates.

… and isn't appropriate for library NuGets.

…pinning.

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj

src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj

Copilot

Pull request overview

Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.

You can also share your feedback on Copilot code review. Take the survey.

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj

eng/pipelines/onebranch/variables/onebranch-variables.yml

Copilot · 2026-03-10T12:20:10Z

@paulmedynski I've opened a new pull request, #4025, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-03-10T12:20:12Z

@paulmedynski I've opened a new pull request, #4026, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: paulmedynski <31868385+paulmedynski@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

…wnstream outputs (#4025) Co-authored-by: paulmedynski <31868385+paulmedynski@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 35 out of 35 changed files in this pull request and generated 1 comment.

You can also share your feedback on Copilot code review. Take the survey.

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml

Copilot

Pull request overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 3 comments.

You can also share your feedback on Copilot code review. Take the survey.

tools/targets/GenerateMdsPackage.targets

BUILDGUIDE.md

tools/targets/GenerateMdsPackage.targets

Copilot AI review requested due to automatic review settings March 6, 2026 15:52

paulmedynski added the Area\AKV Provider Use this label to tag issues that are targeted for AKV Provider codebase. label Mar 6, 2026

github-project-automation bot added this to SqlClient Board Mar 6, 2026

github-project-automation bot moved this to To triage in SqlClient Board Mar 6, 2026

paulmedynski moved this from To triage to In progress in SqlClient Board Mar 6, 2026

Copilot started reviewing on behalf of paulmedynski March 6, 2026 15:52 View session

paulmedynski commented Mar 6, 2026

View reviewed changes

Copilot AI reviewed Mar 6, 2026

View reviewed changes

eng/pipelines/common/templates/steps/ci-project-build-step.yml Show resolved Hide resolved

tools/specs/Microsoft.Data.SqlClient.nuspec Outdated Show resolved Hide resolved

BUILDGUIDE.md Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 6, 2026 19:27

Copilot started reviewing on behalf of paulmedynski March 6, 2026 19:27 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

tools/props/Versions.props Show resolved Hide resolved

tools/specs/Microsoft.Data.SqlClient.nuspec Outdated Show resolved Hide resolved

BUILDGUIDE.md Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 6, 2026 20:53

Copilot started reviewing on behalf of paulmedynski March 6, 2026 20:54 View session

paulmedynski commented Mar 6, 2026

View reviewed changes

tools/targets/GenerateMdsPackage.targets Outdated Show resolved Hide resolved

Copilot AI reviewed Mar 6, 2026

View reviewed changes

build.proj Outdated Show resolved Hide resolved

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 9, 2026 11:47

Copilot started reviewing on behalf of paulmedynski March 9, 2026 11:48 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj Show resolved Hide resolved

build.proj Show resolved Hide resolved

paulmedynski commented Mar 9, 2026

View reviewed changes

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

build.proj Show resolved Hide resolved

build.proj Show resolved Hide resolved

build.proj Show resolved Hide resolved

paulmedynski added this to the 7.0.0 milestone Mar 9, 2026

Copilot AI review requested due to automatic review settings March 9, 2026 15:44

Copilot started reviewing on behalf of paulmedynski March 9, 2026 15:44 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

BUILDGUIDE.md Show resolved Hide resolved

paulmedynski marked this pull request as ready for review March 9, 2026 19:10

paulmedynski requested a review from a team as a code owner March 9, 2026 19:10

Copilot AI review requested due to automatic review settings March 9, 2026 19:10

Copilot started reviewing on behalf of paulmedynski March 9, 2026 19:10 View session

paulmedynski commented Mar 9, 2026

View reviewed changes

eng/pipelines/onebranch/steps/build-all-configurations-signed-dlls-step.yml Show resolved Hide resolved

Directory.Packages.props Show resolved Hide resolved

Copilot AI reviewed Mar 9, 2026

View reviewed changes

Directory.Packages.props Show resolved Hide resolved

paulmedynski added 8 commits March 10, 2026 08:55

Addressed more PR comments.

db83ab7

Fixed pipeline use of PackAkvProvider, and added InstallNuget propert…

30b1fba

…y to inhibit NuGet.exe download when generating SqlClient package.

Fixing how/when we generate SqlClient nuget and which NuGet executabl…

43fba49

…e to use.

- Fixed CI project build flow AKV pack steps.

c706ed7

- Fixed CI package build flow MDS build steps.

Addressed Copilot feedback.

a5a0f86

Changed OneBranch builds to use the common csproj-based jobs/steps an…

ec04a57

…d removed the obsolete AKV-specific templates.

Disabling transitive pinning since it pollutes our NuGet dependencies…

f4f4f08

… and isn't appropriate for library NuGets.

Fixed build issues with Manual Tests exposed by disabling transitive …

39a9974

…pinning.

Copilot AI review requested due to automatic review settings March 10, 2026 11:59

paulmedynski force-pushed the dev/paul/akv-netstandard branch from 30d23f5 to 39a9974 Compare March 10, 2026 11:59

Copilot started reviewing on behalf of paulmedynski March 10, 2026 11:59 View session

paulmedynski commented Mar 10, 2026

View reviewed changes

src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/UDTs/Address/Address.csproj Show resolved Hide resolved

src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj Show resolved Hide resolved

Copilot AI reviewed Mar 10, 2026

View reviewed changes

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj Show resolved Hide resolved

eng/pipelines/onebranch/variables/onebranch-variables.yml Show resolved Hide resolved

Copilot AI mentioned this pull request Mar 10, 2026

Fix AKV Provider ref project reference propagating ref assembly to downstream outputs #4025

Merged

Copilot AI mentioned this pull request Mar 10, 2026

Fix AKV Provider release publish job artifact name mismatch #4026

Merged

Copilot AI and others added 2 commits March 10, 2026 09:46

Fix AKV Provider release publish job artifact name mismatch (#4026)

dc478c2

Co-authored-by: paulmedynski <31868385+paulmedynski@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Fix AKV Provider ref project reference propagating ref assembly to do…

0bbf5df

…wnstream outputs (#4025) Co-authored-by: paulmedynski <31868385+paulmedynski@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings March 10, 2026 12:46

Copilot started reviewing on behalf of paulmedynski March 10, 2026 12:46 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

.../AzureKeyVaultProvider/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj Show resolved Hide resolved

Fixed newly exposed pruning issues.

485f779

mdaigle previously approved these changes Mar 10, 2026

View reviewed changes

eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml Show resolved Hide resolved

Merge branch 'main' into dev/paul/akv-netstandard

957fe95

Copilot AI review requested due to automatic review settings March 10, 2026 19:23

paulmedynski dismissed mdaigle’s stale review via 957fe95 March 10, 2026 19:23

Copilot started reviewing on behalf of paulmedynski March 10, 2026 19:24 View session

Copilot AI reviewed Mar 10, 2026

View reviewed changes

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

BUILDGUIDE.md Show resolved Hide resolved

tools/targets/GenerateMdsPackage.targets Show resolved Hide resolved

Addressed Copilot comments.

467ec7d

Conversation

paulmedynski commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 10, 2026

Uh oh!

Copilot AI commented Mar 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

paulmedynski commented Mar 6, 2026 •

edited

Loading

codecov bot commented Mar 6, 2026 •

edited

Loading