Skip to content

avoid tostring in SqlConnectionEncryptOptionConverter if we know value is a string #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SimonCropp wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

avoid tostring in SqlConnectionEncryptOptionConverter if we know value is a string #4012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlConnectionEncryptOptionConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ public override bool CanConvertTo(ITypeDescriptorContext context, Type sourceTyp
// Overrides the ConvertFrom method of TypeConverter.
public override object ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, object value)
{
if (value is string)
if (value is string s)
{
return SqlConnectionEncryptOption.Parse(value.ToString());
return SqlConnectionEncryptOption.Parse(s);
}
throw ADP.ConvertFailed(value.GetType(), typeof(SqlConnectionEncryptOption), null);
}
Expand Down
Loading