Open
Conversation
Change local SqlCommand instantiation to a using declaration so paramsCmd is disposed automatically. This ensures the command is disposed at the end of the scope and prevents potential resource leaks while preserving the CommandType = StoredProcedure initialization.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves resource management in SqlCommand.DeriveParameters() by ensuring a locally-created SqlCommand used for parameter discovery is disposed deterministically.
Changes:
- Converted the local
paramsCmdinstantiation to a C#usingdeclaration so it is disposed automatically at the end of the method scope.
paulmedynski
added
the
Code Health 💊
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change local SqlCommand instantiation to a using declaration so paramsCmd is disposed automatically.