-
Notifications
You must be signed in to change notification settings - Fork 317
Tests | ActiveIssues (Part 4) #3750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d543a1b
Reenable tests in SqlCommandCancelTest: TimeoutCancelTcp, TimeoutCanc…
benrr101 cafa83b
Reenable tests in SqlCredentialTest - SqlConnectionChangePasswordPlai…
benrr101 b5dd2fe
Very light cleanup of SqlCredentialTest
benrr101 0815d29
Reenable MarsSessionPoolingTest in MarsExecuteReader_Text_WithGC and …
benrr101 317f456
Split tests into separate tests for each scenario, discover which tes…
benrr101 20f46f7
Mostly working . Except for those no close tests
benrr101 c1f9ac1
Clean up old code, but the nocloses test still breaks everything - ne…
benrr101 814736f
Clean up a biiiit more
benrr101 d2a7930
Finishing test matrix, improving DisposableArray, renaming test file …
benrr101 099bc0b
Final iteration of tests, adding backoff to DMV queries, adding #null…
benrr101 976c6fe
Fix mistakes in MARS tests
benrr101 f17d382
Rewrite TimeoutCancel to use less custom utilities - hopefully this w…
benrr101 9dec519
Fix session => request comment
benrr101 55887af
Re-disable TimeoutCancelNamedPipe due to bug in managed SNI implement…
benrr101 27e9f3d
Remove AreConnStringsNotAzureSynapse
benrr101 a41e768
Merge branch 'main' into dev/russellben/active-issues4
benrr101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
50 changes: 50 additions & 0 deletions
50
src/Microsoft.Data.SqlClient/tests/Common/DisposableArray.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
| using System; | ||
| using System.Collections; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Microsoft.Data.SqlClient.Tests.Common | ||
| { | ||
| public class DisposableArray<T> : IDisposable, IEnumerable<T> | ||
mdaigle marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| where T : IDisposable | ||
| { | ||
| private readonly T[] _elements; | ||
|
|
||
| public T this[int i] | ||
| { | ||
| get => _elements[i]; | ||
| set => _elements[i] = value; | ||
| } | ||
|
|
||
| public int Length => _elements.Length; | ||
|
|
||
| public DisposableArray(int size) | ||
| { | ||
| _elements = new T[size]; | ||
| } | ||
|
|
||
| public DisposableArray(T[] elements) | ||
| { | ||
| _elements = elements; | ||
| } | ||
|
|
||
| public void Dispose() | ||
| { | ||
| foreach (T element in _elements) | ||
| { | ||
| element?.Dispose(); | ||
paulmedynski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| } | ||
|
|
||
| GC.SuppressFinalize(this); | ||
| } | ||
|
|
||
| public IEnumerator<T> GetEnumerator() => | ||
| ((IEnumerable<T>)_elements).GetEnumerator(); | ||
|
|
||
| IEnumerator IEnumerable.GetEnumerator() => | ||
| _elements.GetEnumerator(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
276 changes: 0 additions & 276 deletions
276
...oft.Data.SqlClient/tests/ManualTests/SQL/MARSSessionPoolingTest/MARSSessionPoolingTest.cs
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.