Skip to content

Enable User Agent Extension #3530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Enable User Agent Extension #3530

wants to merge 15 commits into from

Conversation

samsharma2700
Copy link
Contributor

Description

This is the final PR(part 3) for User Agent Feature Extension work. Making this a draft since we want few changes on part 2 : #3489
This PR will be updated once part 2 is merged.

Majority of changes in this PR include:

  • Enabling UserAgent FE for prelogin.
  • More tests relating to functionality of FE.
  • Adding traces.
  • Enable/Pass the encoded JSON byte payload.

Testing

Builds are passing. Added unit tests and functional tests

@samsharma2700
Add Feature Extension for User Agent
27a8795
@samsharma2700
resolving merge conflicts
035d6b2
@samsharma2700
resolve conflicts
a27be5d
@samsharma2700
Merge remote-tracking branch 'origin/main' into sam_feat_uagent
8cf667f
@samsharma2700
Add summary and review changes
9509553
@samsharma2700
Merge branch 'main' of https://github.com/dotnet/SqlClient into sam_f…
ff70662 
…eat_uagent
@samsharma2700
Adding functional test for User Agent
679baee
@samsharma2700
Add UserAgent Json payload
5fc8f70
@samsharma2700
Merge branch 'main' of https://github.com/dotnet/SqlClient into sam_f…
6b2b6d8 
…eat_jsonuagent
@samsharma2700
Add unit tests and update UserAgentInfo payload checks
5147858
@samsharma2700
PR review changes 1
7b2ad0e
@samsharma2700
Sync with main
e9c2d81
@samsharma2700
Resolve conflicts
1884906
@samsharma2700
Merge branch 'sam_feat_jsonuagent' of https://github.com/dotnet/SqlCl…
0d5fdf8 
…ient into sam_test_uagent
@samsharma2700
Enable writing Json payload for UserAgent
e30f51b
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

paulmedynski
paulmedynski requested changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few problems to address.

@Wraith2
Copy link
Contributor

Wraith2 commented Aug 12, 2025

What's a user agent and what can users do with them?

@ErikEJ
Copy link
Contributor

ErikEJ commented Aug 13, 2025

@Wraith2 I think it is similar to the User Agent string submitted by a browser, and can be used for telemetry from the server side.

@paulmedynski
Copy link
Contributor

We're using the term User Agent in the generic sense - MDS is an agent acting on the user's behalf to talk to a SQL Server. This feature will calculate a JSON payload with details of the environment that MDS is running in and supply that to SQL Server for temeletry/reporting purposes, similar to what a web browser does with the HTTP User-Agent header.

@cheenamalhotra cheenamalhotra added this to the 7.0-preview1 milestone Aug 15, 2025
@paulmedynski paulmedynski self-assigned this Sep 4, 2025
@cheenamalhotra cheenamalhotra removed this from the 7.0-preview1 milestone Sep 9, 2025
@paulmedynski
Copy link
Contributor

Superceded by #3606 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmedynski paulmedynski paulmedynski requested changes

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@paulmedynski paulmedynski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samsharma2700 @paulmedynski @Wraith2 @ErikEJ @cheenamalhotra