Fix sequential text reader bug and add covering test #3383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
mdaigle
previously approved these changes
May 29, 2025
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
previously approved these changes
May 29, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlSequentialTextReader.cs
Outdated
Show resolved
Hide resolved
|
|
||
| StringBuilder resultBuilder = new StringBuilder(); | ||
| CancellationTokenSource cts = new CancellationTokenSource(); | ||
| using (var connection = new SqlConnection(DataTestUtility.TCPConnectionString)) |
There was a problem hiding this comment.
More curiosity than request: for unit tests, I'm usually more liberal with usage of using statements vs blocks, so I'm wondering if your preference for the blocks is to trigger a disposal before running assertions or if behavior has no impact here and it's just a style preference.
There was a problem hiding this comment.
Purely style. It would work with blocks the same way as with statements. I learnt c# at the first version and there are some newer idioms that I simply prefer not to use. In general I like to have very clear scoped blocks to help me visually understand what's in and out of scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3361
When using single byte input the test provided triggered a condition where the next read would skip data in available internal buffer because it was exactly, and not less than, the required amount.
/cc @m0a0k0s