Define JSON Schema for user agent payload #3378
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a JSON Schema definition for the user agent payload sent during driver login and updates the EditorConfig to use a 2-space indent for JSON and JSONC files.
- Added spec/user-agent.jsonc to define the structure and validation rules for the user agent payload.
- Updated .editorconfig to include all JSON and JSONC files with a 2-space indent.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spec/user-agent.jsonc | New JSON schema defining user agent payload. |
| .editorconfig | Updated JSON section to enforce 2-space indents. |
- Created a JSON Schema that defines the user agent JSON payload format.
paulmedynski
force-pushed
the
dev/paul/user-agent
branch
from
dbafc5f to
d095fb0
Compare
- Removed "ext" section, which needs further planning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3378 +/- ##
==========================================
- Coverage 64.47% 64.47% -0.01%
==========================================
Files 298 298
Lines 65525 65525
==========================================
- Hits 42248 42244 -4
- Misses 23277 23281 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Renamed to identify as v1 of the schema.
benrr101
approved these changes
May 29, 2025
mdaigle
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defines a JSON schema for V1 of the user agent JSON payload. Full feature spec is here:
https://microsoft.sharepoint-df.com/:w:/t/sqldevx/ERIWTt0zlCxLroNHyaPlKYwBI_LNSff6iy_wXZ8xX6nctQ?e=8yuhBi
I also updated the EditorConfig to use 2 space indent for all JSON files.