Merge | Port #528 and #2091 to netfx

[edwardneal]

Description

This ports an earlier set of memory usage reductions from netcore to netfx.

Issues

Relates to #1261.
Ports #528 and #2091.

Testing

Unit tests pass locally. I don't see anything specifically targeting these changes, so I assume that they're covered by the overall test suite - they're fairly frequently exercised.

[cheenamalhotra]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[paulmedynski]

A couple of spurious ? checks.

I didn't dig into the full logic that was added/modified - I don't have enough experience with SqlCommand for that yet.

[cheenamalhotra]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[codecov]

Codecov Report

Attention: Patch coverage is 96.64430% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.80%. Comparing base (b8948f2) to head (d60c800).
Report is 9 commits behind head on main.

Files with missing lines	Patch %	Lines
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs	97.27%	4 Missing ⚠️
...netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs	50.00%	1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (b8948f2) and HEAD (d60c800). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (b8948f2)	HEAD (d60c800)
addons	1	0

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3376      +/-   ##
==========================================
- Coverage   67.04%   58.80%   -8.25%     
==========================================
  Files         300      292       -8     
  Lines       65376    65307      -69     
==========================================
- Hits        43831    38403    -5428     
- Misses      21545    26904    +5359     

Flag	Coverage Δ
addons	?
netcore	62.80% <50.00%> (-9.40%)	⬇️
netfx	59.88% <97.27%> (-5.30%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[benrr101]

Since this is porting changes into netfx, I'm onboard with these changes