-
Notifications
You must be signed in to change notification settings - Fork 308
Merge | DbConnectionOptions Prep Work #3343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
benrr101
merged 13 commits into
main
from
dev/russellben/merge/dbconnectionoptions-debug
May 29, 2025
Merged
Merge | DbConnectionOptions Prep Work #3343
benrr101
merged 13 commits into
main
from
dev/russellben/merge/dbconnectionoptions-debug
May 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
==========================================
- Coverage 64.47% 64.46% -0.02%
==========================================
Files 298 299 +1
Lines 65525 65525
==========================================
- Hits 42248 42239 -9
- Misses 23277 23286 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
previously approved these changes
May 12, 2025
mdaigle
approved these changes
May 12, 2025
…Keywords and DbConnectionStringSynonyms Some light cleanup for nearby code
Drop common from filename
…fx suffix Change reference to common project DbConnectionOptions.cs
…etcore suffix Change reference to common project DbConnectionOptions.cs
…e all instances to ConnectionString namespace
485976b
to
d6b1244
Compare
mdaigle
previously approved these changes
May 16, 2025
paulmedynski
previously approved these changes
May 22, 2025
# Conflicts: # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPool.cs # src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolGroup.cs
mdaigle
approved these changes
May 29, 2025
benrr101
commented
May 29, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPool.cs
Show resolved
Hide resolved
...icrosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/DbConnectionPoolGroup.cs
Show resolved
Hide resolved
paulmedynski
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This one does some misc work before merging the netfx and netcore DbConnectionOptions partials into the existing DbConnectionOptions class. I could probably just merge it all together in one PR, but it feels like this should be its own PR.
Testing: Everything still builds and should pass tests