-
Notifications
You must be signed in to change notification settings - Fork 308
Use NonOfficial template for signing test #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3293 +/- ##
==========================================
+ Coverage 72.97% 73.02% +0.05%
==========================================
Files 298 298
Lines 57001 57001
==========================================
+ Hits 41596 41627 +31
+ Misses 15405 15374 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is also used as the definition for dotnet-sqlclient-Official. I assume that pipeline will fail if we use the NonOfficial template.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get a better understanding of the goal of this change. The default behavior of the nonofficial template is that it'll break the build on APIScan errors, while the official template will raise APIScan errors as TSA bugs (which are currently not working as expected). The template can be changed when starting the pipeline, so I presume this change is only supposed to apply to nightly-type builds. Afaik, this will cause our nightly builds to fail all the time since we still have unresolved APIScan errors.
I think we need to determine what we expect builds to do in each case (and modify the pipeline accordingly):
- Manual builds for release process - imho, should break the build
- Manual builds for testing purposes - imho, should break the build
- Automatic builds for nightly stuff - imho, should raise TSA bugs.
We can make those changes, but it will be a slightly more complex change than just changing the default onebranch template. And if we want to adopt my suggestions, this change basically does the opposite of all of those 😅
My changes in #3298 allow the dotnet-sqlclient-Official pipeline in ADO to run as NonOfficial and succeed. See: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=114046&view=results |
Once we port this to main, we can then enable non-official build by default. |
Addresses test signing pipeline trigger issues