Merge | Cleanup Pre 2005 Support in TdsParser #3085
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3085 +/- ##
==========================================
+ Coverage 72.74% 72.75% +0.01%
==========================================
Files 283 283
Lines 58968 58883 -85
==========================================
- Hits 42894 42839 -55
+ Misses 16074 16044 -30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Looks good to me. Once this PR's merged, I've got a branch ready to submit (diff - about half the size of this PR) which chases the references to |
paulmedynski
requested changes
Mar 7, 2025
| private bool _is2000SP1 = false; // set to true if speaking to 2000 SP1 or later | ||
|
|
||
| private bool _is2005 = false; // set to true if speaking to 2005 or later | ||
| private bool _is2005 = false; |
There was a problem hiding this comment.
I think we should remove this field entirely.
|
Meant to close this in favor of #3206 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #2839 is merged, the Pre 2005 Code can be removed from netfx to align netfx & netcore code for future merge of TdsParser.
It also removes asserts that were used to gate 2005-only code
The code does not aim to remove Pre 2005 Code from other classes
This is working towards #2953