Provide Table Explicit Properties - #1149 #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but looks like you need to sign the CLA. Can you also give it a better title? |
mikeebowen
requested changes
Apr 25, 2025
| /// <summary> | ||
| /// Gets the collection of table cells within the table row. | ||
| /// </summary> | ||
| public IEnumerable<TableCell>? TableCell |
There was a problem hiding this comment.
since this is an IEnumerable, I think plural TableCells would be a better name
There was a problem hiding this comment.
And do we currently return nullable enumerables? I'd prefer to return an empty enumerable, but we should follow whatever the pattern is
There was a problem hiding this comment.
@twsouthwick I applied changes you and Mike recommended can I have this PR re reviewed/approved Thanks
…wiak/Open-XML-SDK into add-table-properties-1149
|
@dotnet-policy-service agree company="Microsoft" |
mikeebowen
approved these changes
Apr 28, 2025
|
Hi @twsouthwick @tomjebo — could I kindly get one more review/approval on this PR? It’s been open for a while now. Thanks a lot! |
twsouthwick
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #1149