Improve method naming for conversions to pointers #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
6591
to
6596
| var pointerSuffix = ""; | ||
| if (pointerIndirectionLevel > 0) | ||
| { | ||
| pointerSuffix = string.Concat(Enumerable.Repeat("Pointer", pointerIndirectionLevel)); | ||
| } | ||
| name = $"To{returnTypeName}{pointerSuffix}"; |
Member
There was a problem hiding this comment.
This is going to be quite expensive for the most common case of "no suffix" and the second less common case of "1 indirection".
I would expect that repeated levels of indirections become increasingly less common, and that it is worth special casing at least 0, 1, 2 levels and to leave everything else to the "expensive" path using Enumerable.
Contributor
Author
There was a problem hiding this comment.
Do you prefer ToInt32PointerPointer or ToInt32Pointer2?
Contributor
Author
There was a problem hiding this comment.
Do you prefer
ToInt32PointerPointerorToInt32Pointer2?
I assumed the latter since it's more efficient and scales better, but I'd be happy to switch if you prefer the former.
tests/ClangSharp.PInvokeGenerator.UnitTests/CSharpCompatibleUnix/CXXMethodDeclarationTest.cs
Outdated
Show resolved
Hide resolved
ds5678
force-pushed
the
conversions-to-pointer
branch
from
73bca45 to
2c3733e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.