-
Notifications
You must be signed in to change notification settings - Fork 25k
[11.0 P1] Blazor release notes and initial migration guidance #36449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@tdykstra @wadepickett ... I needed the Migration infrastructure in place for Blazor migration coverage. I've added it to this PR that adds blazor INCLUDES coverage for the Release notes article. |
tdykstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
|
||
| The inline JS event handler that toggles the display of navigation links is no longer present in the `NavMenu` component of the Blazor Web App project template. Apps generated from the project template now use a [collocated JS module](xref:blazor/js-interop/javascript-location#load-a-script-from-an-external-javascript-file-js-collocated-with-a-component) approach to show or hide the navigation bar on the rendered page. The new approach improves [Content Security Policy (CSP) compliance](xref:blazor/security/content-security-policy) because it doesn't require the CSP to include an unsafe hash for the inline JS. | ||
|
|
||
| To migrate an existing app to .NET 11, including adopting the new JS module approach for the navigation bar toggler, see <xref:migration/100-to-110>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be an blank line on the end since this is an include?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there should be a newline at the end of every last content line for every file in GH ... thus a blank line showing at the end of every file.
|
Thanks, @tdykstra ... I forgot to place the INCLUDES file in a folder named "includes" 💥. |
Co-authored-by: Wade Pickett <[email protected]>
|
The warnings that will appear here are the standard filename warnings. IMO, they should get rid of those, but we have a lot to update to address all of them, including the underscores in many folders around the repo (I have an issue to work on that at some point). |
wadepickett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Approved.
See my question/suggestion around what I think might be a typo for .NET 10 vs .NET 11.
Co-authored-by: Wade Pickett <[email protected]>
Addresses #36448
Internal previews