Updated the documentation to use aspnetcore sample code. #35186
Conversation
|
@dotnet-policy-service agree |
|
@wadepickett can you add support for linking to https://github.com/dotnet/aspnetcore to our repo like we did with https://github.com/dotnet/AspNetCore.Docs.Samples ? |
wadepickett
requested review from
Rick-Anderson
and removed request for
wadepickett
|
@Rick-Anderson, I changed the review request to you for your topic. I can't do this one. |
@Rick-Anderson, I moved this discussion to an email thread to figure out details. Thanks. |
| @@ -11,15 +11,15 @@ uid: security/authorization/iard | |||
|
|
|||
| Consider the following sample that implements a custom `MinimumAgeAuthorizationHandler`: | |||
|
|
|||
| :::code language="csharp" source="~/../AspNetCore.Docs.Samples/security/authorization/AuthRequirementsData/Program.cs" highlight="9"::: | |||
| :::code language="csharp" source="~/../aspnetcore/src/Security/samples/CustomPolicyProvider/Startup.cs" highlight="23"::: | |||
There was a problem hiding this comment.
Since I'm not up yet on the intent here you may need to disregard, but I see this is moving back to before .NET 6 using Startup.cs rather than Program.cs. Maybe that is intentional, but I'll call it out just in case. @Rick-Anderson who owns the security topics can determine what is right for it, so let him weigh in first.
There was a problem hiding this comment.
Hi @wadepickett, I noticed that as well. Is there an updated code sample we can refer to? If not, it might be best to submit a PR to update the aspnetcore repo sample with the .NET 9/10 pattern first, before this PR.
There was a problem hiding this comment.
Hi @wadepickett, I noticed that as well. Is there an updated code sample we can refer to? If not, it might be best to submit a PR to update the aspnetcore repo sample with the .NET 9/10 pattern first, before this PR.
Yes, a PR would be welcome. Before doing the PR, propose the work you intend to do in dotnet/aspnetcore#61437 and get approval.
|
Let's table this issue until dotnet/aspnetcore#61437 closes. |
Fixes #35045
Removed ASPNETCORE.Docs sample and replace with test code sample in /dotnet/aspnetcore repository.
Internal previews