Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc-start to .NET 9 #34603

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Conversation

timdeschryver
Copy link
Contributor

@timdeschryver timdeschryver commented Jan 30, 2025

Closes #34560

This PR:

  • Moves the existing .NET 8 docs to its separate file
  • Updates the current article to .NET 9
    • Removes instructions for Mac
    • Updates references to .NET 9
    • Updates VS code terminal link to new link (the old one gets redirected to this one)
    • Updates logs
  • Adds .NET 9 sample

Internal previews

📄 File 🔗 Preview link
aspnetcore/tutorials/grpc/grpc-start.md aspnetcore/tutorials/grpc/grpc-start
aspnetcore/tutorials/grpc/grpc-start/sample/sample9/readme.md aspnetcore/tutorials/grpc/grpc-start/sample/sample9/readme

@Rick-Anderson Rick-Anderson self-requested a review January 30, 2025 20:49
Updated to 9.0 for framework selection in VS
@wadepickett wadepickett self-assigned this Jan 30, 2025
@wadepickett wadepickett self-requested a review January 30, 2025 21:16
Copy link
Contributor

@wadepickett wadepickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timdeschryver, this looks great! I committed some small fixes, and I approve with those in. I also tested the app sample.
Cool that you noticed the VS for Mac tab needed to be removed for this version as well. It did. Did Rick mention that?

Thanks for the great work!

@wadepickett wadepickett merged commit cee85cb into dotnet:main Jan 30, 2025
3 checks passed
@timdeschryver
Copy link
Contributor Author

@timdeschryver, this looks great! I committed some small fixes, and I approve with those in. I also tested the app sample. Cool that you noticed the VS for Mac tab needed to be removed for this version as well. It did. Did Rick mention that?

Thanks for the great work!

Thanks Wade, and thanks for the small fixes!
I knew that the support for Mac is dropped, and I think I saw another PR or issue also removing the tab.

@wadepickett
Copy link
Contributor

wadepickett commented Jan 31, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gRPC Get Started: Update code sample to .NET 9
2 participants