-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update grpc-start to .NET 9 #34603
update grpc-start to .NET 9 #34603
Conversation
Updated to 9.0 for framework selection in VS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timdeschryver, this looks great! I committed some small fixes, and I approve with those in. I also tested the app sample.
Cool that you noticed the VS for Mac tab needed to be removed for this version as well. It did. Did Rick mention that?
Thanks for the great work!
Thanks Wade, and thanks for the small fixes! |
[like] Wade Pickett reacted to your message:
…________________________________
From: Tim Deschryver ***@***.***>
Sent: Friday, January 31, 2025 6:49:50 AM
To: dotnet/AspNetCore.Docs ***@***.***>
Cc: Wade Pickett ***@***.***>; State change ***@***.***>
Subject: Re: [dotnet/AspNetCore.Docs] update grpc-start to .NET 9 (PR #34603)
@timdeschryver<https://github.com/timdeschryver>, this looks great! I committed some small fixes, and I approve with those in. I also tested the app sample. Cool that you noticed the VS for Mac tab needed to be removed for this version as well. It did. Did Rick mention that?
Thanks for the great work!
Thanks Wade, and thanks for the small fixes!
I knew that the support for Mac is dropped, and I think I saw another PR or issue also removing the tab.
—
Reply to this email directly, view it on GitHub<#34603 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACTZ66BQ6EZ72D5S4UWP37T2NMMI5AVCNFSM6AAAAABWF55R4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRWGQZTCMZZGM>.
You are receiving this because you modified the open/close state.Message ID: ***@***.***>
|
Closes #34560
This PR:
using GrpcGreeterClient
, but this is requiredInternal previews