Skip to content

尝试 传入 peerName 获取契约代理对象 #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

afunc233
Copy link

Copy link
Member

@lindexi lindexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢,但是有一点实现上我需要想一下

@@ -79,6 +90,22 @@ protected GeneratedIpcProxy()
TypeName = typeof(TContract).FullName!;
}


private void ChackPeerProxy()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉调用过这个方法还是无法保证 PeerProxy 存在

@@ -43,7 +43,7 @@ public IpcProvider(string pipeName, IpcConfiguration? ipcConfiguration = null)
/// <inheritdoc />
public IpcContext IpcContext { get; }

private PeerManager PeerManager { get; }
internal PeerManager PeerManager { get; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个开出来有一点点危险,好在是框架内使用

@@ -6,6 +6,7 @@
<Nullable>enable</Nullable>
<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
<DefineConstants>$(DefineConstants)TRACE;PublicAsInternal</DefineConstants>
<Version>2.0.0</Version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本号是写在 build\Version.props 文件里面,在 dotnet 职业技术学院组织里面大部分都是这样的方式

@@ -35,7 +36,7 @@

<ItemGroup Condition="'$(GITHUB_ACTIONS)' == 'true'">
<!-- 链接源代码到 GitHub 仓库,方便调试 -->
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="2.0.0" PrivateAssets="All" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

升级库推荐是单独开一个

proxy.RuntimeConfigs = ipcProxyConfigs;
}

if (ipcProvider is dotnetCampus.Ipc.Pipes.IpcProvider provider)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个实现方式我需要想一下

@lindexi lindexi deleted the branch dotnet-campus:t/walterlv/upgrade July 17, 2024 06:41
@lindexi lindexi closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants